firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix issue 32212 Text field keyboard selection crashes (#32256)

Browse Source
This commit is contained in:
chunhtai 2019-05-07 15:07:11 -07:00 committed by GitHub
parent c27d10bf46
commit 21efdff8a5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter/lib/src/rendering/editable.dart
View File

@ -428,7 +428,7 @@ class RenderEditable extends RenderBox {
int _handleHorizontalArrows(bool rightArrow, bool leftArrow, bool shift, int newOffset) { int _handleHorizontalArrows(bool rightArrow, bool leftArrow, bool shift, int newOffset) {
// Set the new offset to be +/- 1 depending on which arrow is pressed // Set the new offset to be +/- 1 depending on which arrow is pressed
// If shift is down, we also want to update the previous cursor location // If shift is down, we also want to update the previous cursor location
if (rightArrow && _extentOffset < text.text.length) { if (rightArrow && _extentOffset < text.toPlainText().length) {
newOffset += 1; newOffset += 1;
if (shift) if (shift)
_previousCursorLocation += 1; _previousCursorLocation += 1;

17
packages/flutter/test/material/text_field_test.dart
View File

@ -2973,6 +2973,23 @@ void main() {
expect(controller.selection.extentOffset - controller.selection.baseOffset, 1); expect(controller.selection.extentOffset - controller.selection.baseOffset, 1);
}); });
testWidgets('Shift test 2', (WidgetTester tester) async {
await setupWidget(tester);
const String testValue = 'abcdefghi';
await tester.showKeyboard(find.byType(TextField));
tester.testTextInput.updateEditingValue(const TextEditingValue(
text: testValue,
selection: TextSelection.collapsed(offset: 3),
composing: TextRange(start: 0, end: testValue.length)
));
await tester.pump();
sendKeyEventWithCode(22, true, true, false);
await tester.pumpAndSettle();
expect(controller.selection.extentOffset - controller.selection.baseOffset, 1);
});
testWidgets('Control Shift test', (WidgetTester tester) async { testWidgets('Control Shift test', (WidgetTester tester) async {
await setupWidget(tester); await setupWidget(tester);
const String testValue = 'their big house'; const String testValue = 'their big house';