firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

update module_host_with_custom_build_v2_embedding to target android 35 and to use the latest gradle and agp versions (#163542)

Browse Source 
Part of #149836 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
This commit is contained in:
Reid Baker 2025-02-18 13:22:05 -05:00 committed by GitHub
parent 063d0da3c0
commit 22b7473360
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
dev/integration_tests/module_host_with_custom_build_v2_embedding/app/build.gradle
View File

@ -6,7 +6,7 @@ apply plugin: 'com.android.application'
android { android {
namespace = "io.flutter.addtoapp" namespace = "io.flutter.addtoapp"
compileSdk 34 compileSdk 35
// Flutter's CI installs the NDK at a non-standard path. // Flutter's CI installs the NDK at a non-standard path.
// This non-standard structure is initially created by // This non-standard structure is initially created by
@ -25,7 +25,7 @@ android {
defaultConfig { defaultConfig {
applicationId "io.flutter.addtoapp" applicationId "io.flutter.addtoapp"
minSdkVersion 21 minSdkVersion 21
targetSdkVersion 34 targetSdkVersion 35
versionCode 1 versionCode 1
versionName "1.0" versionName "1.0"
} }
@ -36,15 +36,15 @@ android {
// This is required because the `:flutter` project doesn't define this custom build type. // This is required because the `:flutter` project doesn't define this custom build type.
// Without the fallback, the Android plugin will make Gradle exit with the following error: // Without the fallback, the Android plugin will make Gradle exit with the following error:
// `Unable to find a matching variant of project :flutter` // `Unable to find a matching variant of project :flutter`
matchingFallbacks = ['debug'] matchingFallbacks += 'debug'
} }
prod { prod {
initWith release initWith release
matchingFallbacks = ['release'] matchingFallbacks += 'release'
} }
} }
// Test flavors. // Test flavors.
flavorDimensions "version" flavorDimensions += "version"
productFlavors { productFlavors {
demo { demo {
dimension "version" dimension "version"

2
dev/integration_tests/module_host_with_custom_build_v2_embedding/build.gradle
View File

@ -8,7 +8,7 @@ buildscript {
mavenCentral() mavenCentral()
} }
dependencies { dependencies {
classpath 'com.android.tools.build:gradle:8.1.0' classpath 'com.android.tools.build:gradle:8.8.1'
} }
} }

4
dev/integration_tests/module_host_with_custom_build_v2_embedding/gradle/wrapper/gradle-wrapper.properties vendored
View File

@ -1,5 +1,7 @@
distributionBase=GRADLE_USER_HOME distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.12.1-bin.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-all.zip