firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[flutter_test] Fix incorrect missed budget count (#95003)

Browse Source
This commit is contained in:
Jia Hao 2021-12-11 10:44:11 +08:00 committed by GitHub
parent df4d851f25
commit 22dd0f42ef
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 138 additions and 49 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
packages/flutter_test/lib/src/frame_timing_summarizer.dart
View File

@ -294,16 +294,21 @@ class FrameTimingSummarizer {
}; };
} }
// The following helper functions require data sorted /// Returns the 100*p-th percentile of [data].
///
// return the 100*p-th percentile of the data /// [data] must be sorted in ascending order.
T _findPercentile<T>(List<T> data, double p) { T _findPercentile<T>(List<T> data, double p) {
assert(p >= 0 && p <= 1); assert(p >= 0 && p <= 1);
return data[((data.length - 1) * p).round()]; return data[((data.length - 1) * p).round()];
} }
// return the number of items in data that > threshold /// Returns the number of elements in [data] that exceed [threshold].
///
/// [data] must be sorted in ascending order.
int _countExceed<T extends Comparable<T>>(List<T> data, T threshold) { int _countExceed<T extends Comparable<T>>(List<T> data, T threshold) {
return data.length - final int exceedsThresholdIndex = data.indexWhere((T datum) => datum.compareTo(threshold) > 0);
data.indexWhere((T datum) => datum.compareTo(threshold) > 0); if (exceedsThresholdIndex == -1) {
return 0;
}
return data.length - exceedsThresholdIndex;
} }

170
packages/flutter_test/test/frame_timing_summarizer_test.dart
View File

@ -7,51 +7,135 @@ import 'dart:ui';
import 'package:flutter_test/flutter_test.dart'; import 'package:flutter_test/flutter_test.dart';
void main() { void main() {
test('Test FrameTimingSummarizer', () { group(FrameTimingSummarizer, () {
List<int> vsyncTimes = <int>[ test('calculates all fields', () {
for (int i = 0; i < 100; i += 1) 100 * (i + 1), List<int> vsyncTimes = <int>[
]; for (int i = 0; i < 100; i += 1) 100 * (i + 1),
List<int> buildTimes = <int>[ ];
for (int i = 0; i < 100; i += 1) vsyncTimes[i] + 1000 * (i + 1), List<int> buildTimes = <int>[
]; for (int i = 0; i < 100; i += 1) vsyncTimes[i] + 1000 * (i + 1),
List<int> rasterTimes = <int>[ ];
for (int i = 0; i < 100; i += 1) 1000 * (i + 1) + 1000, List<int> rasterTimes = <int>[
]; for (int i = 0; i < 100; i += 1) 1000 * (i + 1) + 1000,
// reversed to make sure sort is working. ];
buildTimes = buildTimes.reversed.toList(); // reversed to make sure sort is working.
rasterTimes = rasterTimes.reversed.toList(); buildTimes = buildTimes.reversed.toList();
vsyncTimes = vsyncTimes.reversed.toList(); rasterTimes = rasterTimes.reversed.toList();
final List<FrameTiming> inputData = <FrameTiming>[ vsyncTimes = vsyncTimes.reversed.toList();
for (int i = 0; i < 100; i += 1) final List<FrameTiming> inputData = <FrameTiming>[
FrameTiming( for (int i = 0; i < 100; i += 1)
vsyncStart: 0, FrameTiming(
buildStart: vsyncTimes[i], vsyncStart: 0,
buildFinish: buildTimes[i], buildStart: vsyncTimes[i],
rasterStart: 500, buildFinish: buildTimes[i],
rasterFinish: rasterTimes[i], rasterStart: 500,
// Wall time should not be used in any profiling metrics. rasterFinish: rasterTimes[i],
// It is primarily to correlate with external tools' measurement. // Wall time should not be used in any profiling metrics.
rasterFinishWallTime: 0, // It is primarily to correlate with external tools' measurement.
), rasterFinishWallTime: 0,
]; ),
];
final FrameTimingSummarizer summary = FrameTimingSummarizer(inputData); final FrameTimingSummarizer summary = FrameTimingSummarizer(inputData);
expect(summary.averageFrameBuildTime.inMicroseconds, 50500); expect(summary.averageFrameBuildTime.inMicroseconds, 50500);
expect(summary.p90FrameBuildTime.inMicroseconds, 90000); expect(summary.p90FrameBuildTime.inMicroseconds, 90000);
expect(summary.p99FrameBuildTime.inMicroseconds, 99000); expect(summary.p99FrameBuildTime.inMicroseconds, 99000);
expect(summary.worstFrameBuildTime.inMicroseconds, 100000); expect(summary.worstFrameBuildTime.inMicroseconds, 100000);
expect(summary.missedFrameBuildBudget, 84); expect(summary.missedFrameBuildBudget, 84);
expect(summary.averageFrameRasterizerTime.inMicroseconds, 51000); expect(summary.averageFrameRasterizerTime.inMicroseconds, 51000);
expect(summary.p90FrameRasterizerTime.inMicroseconds, 90500); expect(summary.p90FrameRasterizerTime.inMicroseconds, 90500);
expect(summary.p99FrameRasterizerTime.inMicroseconds, 99500); expect(summary.p99FrameRasterizerTime.inMicroseconds, 99500);
expect(summary.worstFrameRasterizerTime.inMicroseconds, 100500); expect(summary.worstFrameRasterizerTime.inMicroseconds, 100500);
expect(summary.missedFrameRasterizerBudget, 85); expect(summary.missedFrameRasterizerBudget, 85);
expect(summary.frameBuildTime.length, 100); expect(summary.frameBuildTime.length, 100);
expect(summary.averageVsyncOverhead.inMicroseconds, 5050); expect(summary.averageVsyncOverhead.inMicroseconds, 5050);
expect(summary.p90VsyncOverhead.inMicroseconds, 9000); expect(summary.p90VsyncOverhead.inMicroseconds, 9000);
expect(summary.p99VsyncOverhead.inMicroseconds, 9900); expect(summary.p99VsyncOverhead.inMicroseconds, 9900);
expect(summary.worstVsyncOverhead.inMicroseconds, 10000); expect(summary.worstVsyncOverhead.inMicroseconds, 10000);
});
group('missed budget count', () {
test('when single element missed budget', () {
final FrameTimingSummarizer summary = FrameTimingSummarizer(<FrameTiming>[
FrameTiming(
buildStart: 0,
buildFinish: (kBuildBudget + const Duration(microseconds: 1)).inMicroseconds,
vsyncStart: 0,
rasterStart: 0,
rasterFinish: 0,
rasterFinishWallTime: 0,
),
]);
expect(summary.missedFrameBuildBudget, 1);
});
test('when single element within budget', () {
final FrameTimingSummarizer summary = FrameTimingSummarizer(<FrameTiming>[
FrameTiming(
buildStart: 0,
buildFinish: 0,
vsyncStart: 0,
rasterStart: 0,
rasterFinish: 0,
rasterFinishWallTime: 0,
),
]);
expect(summary.missedFrameBuildBudget, 0);
});
test('when single element exactly within budget', () {
final FrameTimingSummarizer summary = FrameTimingSummarizer(<FrameTiming>[
FrameTiming(
buildStart: 0,
buildFinish: kBuildBudget.inMicroseconds,
vsyncStart: 0,
rasterStart: 0,
rasterFinish: 0,
rasterFinishWallTime: 0,
),
]);
expect(summary.missedFrameBuildBudget, 0);
});
test('when many missed budget', () {
final FrameTimingSummarizer summary = FrameTimingSummarizer(<FrameTiming>[
FrameTiming(
buildStart: 0,
buildFinish: 0,
vsyncStart: 0,
rasterStart: 0,
rasterFinish: 0,
rasterFinishWallTime: 0,
),
FrameTiming(
buildStart: 0,
buildFinish: kBuildBudget.inMicroseconds,
vsyncStart: 0,
rasterStart: 0,
rasterFinish: 0,
rasterFinishWallTime: 0,
),
FrameTiming(
buildStart: 0,
buildFinish: (kBuildBudget + const Duration(microseconds: 1)).inMicroseconds,
vsyncStart: 0,
rasterStart: 0,
rasterFinish: 0,
rasterFinishWallTime: 0,
),
FrameTiming(
buildStart: 0,
buildFinish: (kBuildBudget + const Duration(microseconds: 2)).inMicroseconds,
vsyncStart: 0,
rasterStart: 0,
rasterFinish: 0,
rasterFinishWallTime: 0,
),
]);
expect(summary.missedFrameBuildBudget, 2);
});
});
}); });
} }