firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[devicelab] fix web twc task missing display (#56623)

Browse Source
This commit is contained in:
Jonah Williams 2020-05-08 09:50:46 -07:00 committed by GitHub
parent c57092511a
commit 231a055069
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dev/devicelab/bin/tasks/web_enable_twc.dart
View File

@ -9,5 +9,5 @@ import 'package:flutter_devicelab/tasks/track_widget_creation_enabled_task.dart'
/// Verify that twc can be enabled/disabled on the web. /// Verify that twc can be enabled/disabled on the web.
Future<void> main() async { Future<void> main() async {
await task(TrackWidgetCreationEnabledTask('chrome').task); await task(TrackWidgetCreationEnabledTask('chrome', <String>['--web-run-headless']).task);
} }

8
dev/devicelab/lib/tasks/track_widget_creation_enabled_task.dart
View File

@ -18,9 +18,13 @@ final Directory integrationTestDir = Directory(
/// Verifies that track-widget-creation can be enabled and disabled. /// Verifies that track-widget-creation can be enabled and disabled.
class TrackWidgetCreationEnabledTask { class TrackWidgetCreationEnabledTask {
TrackWidgetCreationEnabledTask([this.deviceIdOverride]); TrackWidgetCreationEnabledTask([
this.deviceIdOverride,
this.additionalArgs = const <String>[],
]);
String deviceIdOverride; String deviceIdOverride;
final List<String> additionalArgs;
Future<TaskResult> task() async { Future<TaskResult> task() async {
final File file = File(path.join(integrationTestDir.path, 'info')); final File file = File(path.join(integrationTestDir.path, 'info'));
@ -39,6 +43,7 @@ class TrackWidgetCreationEnabledTask {
final Process runProcess = await startProcess( final Process runProcess = await startProcess(
path.join(flutterDirectory.path, 'bin', 'flutter'), path.join(flutterDirectory.path, 'bin', 'flutter'),
flutterCommandArgs('run', <String>[ flutterCommandArgs('run', <String>[
...?additionalArgs,
'--vmservice-out-file=info', '--vmservice-out-file=info',
'--track-widget-creation', '--track-widget-creation',
'-v', '-v',
@ -73,6 +78,7 @@ class TrackWidgetCreationEnabledTask {
final Process runProcess = await startProcess( final Process runProcess = await startProcess(
path.join(flutterDirectory.path, 'bin', 'flutter'), path.join(flutterDirectory.path, 'bin', 'flutter'),
flutterCommandArgs('run', <String>[ flutterCommandArgs('run', <String>[
...?additionalArgs,
'--vmservice-out-file=info', '--vmservice-out-file=info',
'--no-track-widget-creation', '--no-track-widget-creation',
'-v', '-v',