From 234b50aa532b429bc9eb2e846d0a140850d6304f Mon Sep 17 00:00:00 2001 From: Taha Tesser Date: Wed, 12 Mar 2025 11:51:35 +0200 Subject: [PATCH] Update Material 2 `IconButton` padding documentation (#164383) Fixes [Icon button with padding with wrong splash and highlight position](https://github.com/flutter/flutter/issues/31194) ### Description This PR updates Material 2 `IconButton` padding documentation where using disproportionate padding. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --- packages/flutter/lib/src/material/icon_button.dart | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/packages/flutter/lib/src/material/icon_button.dart b/packages/flutter/lib/src/material/icon_button.dart index 6454952bc6..d1db763adc 100644 --- a/packages/flutter/lib/src/material/icon_button.dart +++ b/packages/flutter/lib/src/material/icon_button.dart @@ -350,6 +350,12 @@ class IconButton extends StatelessWidget { /// The padding around the button's icon. The entire padded icon will react /// to input gestures. /// + /// If [ThemeData.useMaterial3] is set to false, apply padding in the square + /// proportion to the button's splash/highlight shape. For example, if the + /// button is a circle, use padding on all sides to center the icon inside the + /// splash/highlight circle. Otherwise, wrap the [IconButton] with a [Padding] + /// widget to apply padding in the desired direction. + /// /// This property can be null. If null, it defaults to 8.0 padding on all sides. final EdgeInsetsGeometry? padding;