Remove abi key from local golden file testing (#149696)

Fixes https://github.com/flutter/flutter/issues/149435

CI does not comprehensively cover all of the possible abi keys, so some folks can't test locally if their machine's abi does not match CI. This just removes it from the local testing look up. The right image will be summoned, and in CI we can still keep track of it.
This commit is contained in:
Kate Lovett 2024-06-05 18:51:11 -05:00 committed by GitHub
parent c1064da21b
commit 236b3a716d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 4 deletions

View File

@ -579,7 +579,11 @@ class SkiaGoldClient {
final Map<String, Object?> parameters = <String, Object?>{
if (_isBrowserTest)
'Browser' : _browserKey,
'Abi': '$abi',
// This method is only used in local testing to look up the given image.
// CI is not comprehensive in possible abi keys, so false negatives can
// be produced if we include it in local testing. For example CI uses
// macos_x64 but a contributor could have macos_arm64.
// 'Abi': '$abi',
'CI' : 'luci',
'Platform' : platform.operatingSystem,
if (webRenderer != null)

View File

@ -514,7 +514,7 @@ void main() {
expect(
skiaClient.getTraceID('flutter.golden.1'),
equals('d8867d66b8f0be8d0c31598d8370f5dd'),
equals('ae18c7a6aa48e0685525dfe8fdf79003'),
);
});
@ -548,7 +548,7 @@ void main() {
expect(
skiaClient.getTraceID('flutter.golden.1'),
equals('febd0e8ef6512c2a82c964b2a9e60012'),
equals('e9d5c296c48e7126808520e9cc191243'),
);
});
@ -576,7 +576,7 @@ void main() {
);
expect(
skiaClient.getTraceID('flutter.golden.1'),
equals('2e3d3f41cb4470748fa1c941f7762823'),
equals('9968695b9ae78cdb77cbb2be621ca2d6'),
);
});