firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PopupMenuDivider.represents() paramter must be void, not Null (#27195)

Browse Source
This commit is contained in:
Hans Muller 2019-01-28 16:20:18 -08:00 committed by GitHub
parent c082f8d8a3
commit 237fc2fb45
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 56 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/flutter/lib/src/material/popup_menu.dart
View File

@ -110,8 +110,7 @@ class PopupMenuDivider extends PopupMenuEntry<Null> {
final double height;
@override
// ignore: prefer_void_to_null, https://github.com/dart-lang/sdk/issues/34416
bool represents(Null value) => false;
bool represents(void value) => false;
@override
_PopupMenuDividerState createState() => _PopupMenuDividerState();

55
packages/flutter/test/material/popup_menu_test.dart
View File

@ -551,6 +551,61 @@ void main() {
semantics.dispose();
});
testWidgets('PopupMenuButton PopupMenuDivider', (WidgetTester tester) async {
// Regression test for https://github.com/flutter/flutter/issues/27072
String selectedValue;
await tester.pumpWidget(
MaterialApp(
home: Scaffold(
body: Container(
child: Center(
child: PopupMenuButton<String>(
onSelected: (String result) {
selectedValue = result;
},
child: const Text('Menu Button'),
initialValue: '1',
itemBuilder: (BuildContext context) => <PopupMenuEntry<String>>[
const PopupMenuItem<String>(
child: Text('1'),
value: '1',
),
const PopupMenuDivider(),
const PopupMenuItem<String>(
child: Text('2'),
value: '2',
),
],
),
),
),
),
),
);
await tester.tap(find.text('Menu Button'));
await tester.pumpAndSettle();
expect(find.text('1'), findsOneWidget);
expect(find.byType(PopupMenuDivider), findsOneWidget);
expect(find.text('2'), findsOneWidget);
await tester.tap(find.text('1'));
await tester.pumpAndSettle();
expect(selectedValue, '1');
await tester.tap(find.text('Menu Button'));
await tester.pumpAndSettle();
expect(find.text('1'), findsOneWidget);
expect(find.byType(PopupMenuDivider), findsOneWidget);
expect(find.text('2'), findsOneWidget);
await tester.tap(find.text('2'));
await tester.pumpAndSettle();
expect(selectedValue, '2');
});
}
class TestApp extends StatefulWidget {