firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix SliverReorderableLists item wrong offset (#136828)

Browse Source 
This PR fixes the issue of items being created at the wrong position during dragging.

Fixes #135819
This commit is contained in:
yim 2023-10-25 09:11:18 +08:00 committed by GitHub
parent 4afdfca264
commit 25c5bf0640
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 52 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/flutter/lib/src/widgets/reorderable_list.dart
View File

@ -730,6 +730,9 @@ class SliverReorderableListState extends State<SliverReorderableList> with Ticke
}
void _registerItem(_ReorderableItemState item) {
if (_dragInfo != null && _items[item.index] != item) {
item.updateForGap(_dragInfo!.index, _dragInfo!.itemExtent, false, _reverse);
}
_items[item.index] = item;
if (item.index == _dragInfo?.index) {
item.dragging = true;

49
packages/flutter/test/widgets/reorderable_list_test.dart
View File

@ -1356,6 +1356,55 @@ void main() {
expect(tester.takeException(), null);
});
testWidgetsWithLeakTracking(
'When creating a new item, be in the correct position',
(WidgetTester tester) async {
await tester.pumpWidget(
MaterialApp(
home: LayoutBuilder(
builder: (_, BoxConstraints view) {
// The third one just appears on the screen
final double itemSize = view.maxWidth / 2 - 20;
return Scaffold(
body: CustomScrollView(
scrollDirection: Axis.horizontal,
cacheExtent: 0, // The fourth one will not be created in the initial state.
slivers: <Widget>[
SliverReorderableList(
itemBuilder: (BuildContext context, int index) {
return ReorderableDragStartListener(
key: ValueKey<int>(index),
index: index,
child: Builder(
builder: (BuildContext context) {
return SizedBox(
width: itemSize,
child: Text('$index'),
);
},
),
);
},
itemCount: 4,
onReorder: (int fromIndex, int toIndex) {},
),
],
),
);
},
),
),
);
final TestGesture drag = await tester.startGesture(tester.getCenter(find.text('0')));
await tester.pump(kLongPressTimeout);
await drag.moveBy(const Offset(20, 0));
await tester.pump();
expect(find.text('3').hitTestable(at: Alignment.topLeft), findsNothing);
await drag.up();
await tester.pumpAndSettle();
},
);
}
class TestList extends StatelessWidget {