firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix misspelling in tab description (#15449)

Browse Source 
Actual text: "Tab 2 of $3"
Expected text: "Tab 2 of 3"
This commit is contained in:
Marcin Urbański 2018-03-15 00:04:06 +01:00 committed by Hans Muller
parent b0f7da9249
commit 2609876c8f
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter_localizations/lib/src/material_localizations.dart
View File

@ -284,7 +284,7 @@ class GlobalMaterialLocalizations implements MaterialLocalizations {
final String template = _translationBundle.tabLabel; final String template = _translationBundle.tabLabel;
return template return template
.replaceFirst(r'$tabIndex', formatDecimal(tabIndex)) .replaceFirst(r'$tabIndex', formatDecimal(tabIndex))
.replaceFirst(r'tabCount', formatDecimal(tabCount)); .replaceFirst(r'$tabCount', formatDecimal(tabCount));
} }
@override @override

4
packages/flutter_localizations/test/translations_test.dart
View File

@ -82,8 +82,8 @@ void main() {
expect(localizations.pageRowsInfoTitle(1, 10, 100, false), isNot(contains(r'$rowCount'))); expect(localizations.pageRowsInfoTitle(1, 10, 100, false), isNot(contains(r'$rowCount')));
expect(localizations.tabLabel(tabIndex: 2, tabCount: 5), isNotNull); expect(localizations.tabLabel(tabIndex: 2, tabCount: 5), isNotNull);
expect(localizations.tabLabel(tabIndex: 2, tabCount: 5), isNot(contains('tabIndex'))); expect(localizations.tabLabel(tabIndex: 2, tabCount: 5), isNot(contains(r'$tabIndex')));
expect(localizations.tabLabel(tabIndex: 2, tabCount: 5), isNot(contains('tabCount'))); expect(localizations.tabLabel(tabIndex: 2, tabCount: 5), isNot(contains(r'$tabCount')));
expect(() => localizations.tabLabel(tabIndex: 0, tabCount: 5), throwsAssertionError); expect(() => localizations.tabLabel(tabIndex: 0, tabCount: 5), throwsAssertionError);
expect(() => localizations.tabLabel(tabIndex: 2, tabCount: 0), throwsAssertionError); expect(() => localizations.tabLabel(tabIndex: 2, tabCount: 0), throwsAssertionError);
}); });