From 273441eef2ae2f6cd0823a276bb287cdc973dc4a Mon Sep 17 00:00:00 2001 From: stuartmorgan Date: Thu, 20 Jul 2023 17:14:02 -0700 Subject: [PATCH] Use downgraded analyze for flutter/packages (#130878) Add the `--downgrade` flag to the flutter/packages analyze test, so that it won't get the latest version of dependencies, avoiding out-of-band failures in flutter/flutter due to package publishing events. Fixes https://github.com/flutter/flutter/issues/129633 --- dev/bots/test.dart | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/dev/bots/test.dart b/dev/bots/test.dart index d4aa4e7d23..7d7784ff58 100644 --- a/dev/bots/test.dart +++ b/dev/bots/test.dart @@ -1460,6 +1460,13 @@ Future _runFlutterPackagesTests() async { 'run', toolScript, 'analyze', + // Fetch the oldest possible dependencies, rather than the newest, to + // insulate flutter/flutter from out-of-band failures when new versions + // of dependencies are published. This compensates for the fact that + // flutter/packages doesn't use pinned dependencies, and for the + // purposes of this test using old dependencies is fine. See + // https://github.com/flutter/flutter/issues/129633 + '--downgrade', '--custom-analysis=script/configs/custom_analysis.yaml', ], workingDirectory: checkout.path,