From 279f40d4877fe74d70b5d483088f054f0226bc89 Mon Sep 17 00:00:00 2001 From: Ian Hickson Date: Mon, 3 May 2021 15:19:02 -0700 Subject: [PATCH] Clean up some old and obsolete TODOs of mine (#81631) --- packages/flutter/lib/src/material/theme.dart | 1 - packages/flutter/lib/src/rendering/error.dart | 3 +-- packages/flutter/lib/src/widgets/async.dart | 1 - 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/flutter/lib/src/material/theme.dart b/packages/flutter/lib/src/material/theme.dart index abe09f735c..887f8ada03 100644 --- a/packages/flutter/lib/src/material/theme.dart +++ b/packages/flutter/lib/src/material/theme.dart @@ -221,7 +221,6 @@ class _AnimatedThemeState extends AnimatedWidgetBaseState { @override void forEachTween(TweenVisitor visitor) { - // TODO(ianh): Use constructor tear-offs when it becomes possible, https://github.com/dart-lang/sdk/issues/10659 _data = visitor(_data, widget.data, (dynamic value) => ThemeDataTween(begin: value as ThemeData))! as ThemeDataTween; } diff --git a/packages/flutter/lib/src/rendering/error.dart b/packages/flutter/lib/src/rendering/error.dart index cf9c12a25b..199ca294ca 100644 --- a/packages/flutter/lib/src/rendering/error.dart +++ b/packages/flutter/lib/src/rendering/error.dart @@ -56,8 +56,7 @@ class RenderErrorBox extends RenderBox { /// The message to attempt to display at paint time. final String message; - // TODO(ianh): should be final - ui.Paragraph? _paragraph; + late final ui.Paragraph? _paragraph; @override double computeMaxIntrinsicWidth(double height) { diff --git a/packages/flutter/lib/src/widgets/async.dart b/packages/flutter/lib/src/widgets/async.dart index d91c4a1c68..9223c38496 100644 --- a/packages/flutter/lib/src/widgets/async.dart +++ b/packages/flutter/lib/src/widgets/async.dart @@ -485,7 +485,6 @@ typedef AsyncWidgetBuilder = Widget Function(BuildContext context, AsyncSnaps /// [Stream]. /// * [StreamBuilderBase], which supports widget building based on a computation /// that spans all interactions made with the stream. -// TODO(ianh): remove unreachable code above once https://github.com/dart-lang/linter/issues/1139 is fixed class StreamBuilder extends StreamBuilderBase> { /// Creates a new [StreamBuilder] that builds itself based on the latest /// snapshot of interaction with the specified [stream] and whose build