Revert "Add Crane test to the new Gallery app (#62162)" (#62430)

This reverts commit 1ffdfa81d6ba4258ed586a1b0905de74e3961645.
This commit is contained in:
Jonah Williams 2020-07-28 11:32:34 -07:00 committed by GitHub
parent d169880278
commit 27e13dd53e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 2 additions and 56 deletions

View File

@ -1,33 +0,0 @@
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'dart:async';
import 'dart:io';
import 'package:flutter_devicelab/framework/utils.dart';
import 'package:flutter_devicelab/tasks/new_gallery.dart';
import 'package:flutter_devicelab/framework/adb.dart';
import 'package:flutter_devicelab/framework/framework.dart';
import 'package:path/path.dart' as path;
Future<void> main() async {
deviceOperatingSystem = DeviceOperatingSystem.android;
final Directory galleryParentDir =
Directory.systemTemp.createTempSync('new_gallery_test');
final Directory galleryDir =
Directory(path.join(galleryParentDir.path, 'gallery'));
try {
await task(
NewGalleryPerfTest(
galleryDir,
timelineFileName: 'transitions-crane',
dartDefine: 'onlyCrane=true',
).run,
);
} finally {
rmTree(galleryParentDir);
}
}

View File

@ -12,23 +12,14 @@ import '../framework/framework.dart';
import '../framework/utils.dart';
class NewGalleryPerfTest extends PerfTest {
NewGalleryPerfTest(
this.galleryDir, {
String timelineFileName = 'transitions',
String dartDefine = '',
}) : super(
galleryDir.path,
'test_driver/transitions_perf.dart',
timelineFileName,
dartDefine: dartDefine,
);
NewGalleryPerfTest(this.galleryDir) : super(galleryDir.path, 'test_driver/transitions_perf.dart', 'transitions');
@override
Future<TaskResult> run() async {
// Manually roll the new gallery version for now. If the new gallery repo
// turns out to be updated frequently in the future, we can set up an auto
// roller to update this version.
await getNewGallery('e6357bccc49ec542ca127ca4b26b2b87216d07d5', galleryDir);
await getNewGallery('d00362e6bdd0f9b30bba337c358b9e4a6e4ca950', galleryDir);
return await super.run();
}

View File

@ -357,7 +357,6 @@ class PerfTest {
this.testDriver,
this.needsFullTimeline = true,
this.benchmarkScoreKeys,
this.dartDefine = '',
});
/// The directory where the app under test is defined.
@ -396,9 +395,6 @@ class PerfTest {
/// ```
final List<String> benchmarkScoreKeys;
/// Additional flags for `--dart-define` to control the test
final String dartDefine;
Future<TaskResult> run() {
return internalRun();
}
@ -431,8 +427,6 @@ class PerfTest {
if (writeSkslFileName != null)
...<String>['--write-sksl-on-exit', writeSkslFileName],
if (cacheSkSL) '--cache-sksl',
if (dartDefine.isNotEmpty)
...<String>['--dart-define', dartDefine],
'-d',
deviceId,
]);

View File

@ -820,12 +820,6 @@ tasks:
stage: devicelab
required_agent_capabilities: ["mac/ios"]
new_gallery__crane_perf:
description: >
Measures the performance of the Crane page in the new Flutter Gallery on Android.
stage: devicelab
required_agent_capabilities: ["linux/android"]
fast_scroll_large_images__memory:
description: >
Measures memory usage for scrolling through a list of large images.