Avoid implicitly setting determineDevDependencies: true (it's not a safe operation) (#163711)

Closes https://github.com/flutter/flutter/issues/163706.

Before this PR, the macOS workflow (or, others, but only macOS had a
test) would fail because it calls `refreshPluginsList` manually, and
sometimes it would be `determineDevDependencies: null` and sometimes
`determineDevDependencies: false`.

A value of `determineDevDependencies: null` was interpreted later on as
"find dev dependencies", which is not a safe operation. The only real
change in this PR is `bool determineDevDependencies = false`, so
omitting that parameter means we don't determine dev dependencies.

Added some tests, and opted-in an integration test that was failing.

packages/flutter_tools/lib/src/flutter_plugins.dart

@@ -244,9 +244,8 @@ bool _writeFlutterPluginsList(
   final String? oldPluginsFileStringContent = _readFileContent(pluginsFile);
   bool pluginsChanged = true;
   if (oldPluginsFileStringContent != null) {
-    Object? decodedJson;
     try {
-      decodedJson = jsonDecode(oldPluginsFileStringContent);
+      final Object? decodedJson = jsonDecode(oldPluginsFileStringContent);
       if (decodedJson is Map<String, Object?>) {
         final String jsonOfNewPluginsMap = jsonEncode(pluginsMap);
         final String jsonOfOldPluginsMap = jsonEncode(decodedJson[_kFlutterPluginsPluginListKey]);
@@ -1100,12 +1099,17 @@ void _createPlatformPluginSymlinks(
 /// dependencies declared in `pubspec.yaml`.
 ///
 /// Assumes `pub get` has been executed since last change to `pubspec.yaml`.
+///
+/// Unless explicitly specified, [determineDevDependencies] is disabled by
+/// default; if set to `true`, plugins that are development-only dependencies
+/// may be labeled or, depending on the platform, omitted from metadata or
+/// platform-specific artifacts.
 Future<void> refreshPluginsList(
   FlutterProject project, {
   bool iosPlatform = false,
   bool macOSPlatform = false,
   bool forceCocoaPodsOnly = false,
-  bool? determineDevDependencies,
+  bool determineDevDependencies = false,
   bool? generateLegacyPlugins,
 }) async {
   final List<Plugin> plugins = await findPlugins(

packages/flutter_tools/lib/src/project.dart

@@ -358,7 +358,12 @@ class FlutterProject {
     if (!directory.existsSync() || isPlugin) {
       return;
     }
-    await refreshPluginsList(this, iosPlatform: iosPlatform, macOSPlatform: macOSPlatform);
+    await refreshPluginsList(
+      this,
+      iosPlatform: iosPlatform,
+      macOSPlatform: macOSPlatform,
+      determineDevDependencies: releaseMode ?? false,
+    );
     if (androidPlatform) {
       await android.ensureReadyForPlatformSpecificTooling(deprecationBehavior: deprecationBehavior);
     }

packages/flutter_tools/test/general.shard/project_test.dart

@@ -31,6 +31,12 @@ import '../src/fake_pub_deps.dart';
 import '../src/fakes.dart';
 
 void main() {
+  // TODO(matanlurey): Remove after `explicit-package-dependencies` is enabled by default.
+  // See https://github.com/flutter/flutter/issues/160257 for details.
+  FeatureFlags enableExplicitPackageDependencies() {
+    return TestFeatureFlags(isExplicitPackageDependenciesEnabled: true);
+  }
+
   // TODO(zanderso): remove once FlutterProject is fully refactored.
   // this is safe since no tests have expectations on the test logger.
   final BufferLogger logger = BufferLogger.test();
@@ -272,6 +278,59 @@ void main() {
         await project.regeneratePlatformSpecificTooling();
         expectExists(project.android.hostAppGradleRoot.childFile('local.properties'));
       });
+
+      testUsingContext(
+        'omitted release mode does not determine dev dependencies',
+        () async {
+          // Create a plugin.
+          await aPluginProject();
+          // Create a project that depends on that plugin.
+          final FlutterProject project = await projectWithPluginDependency();
+          // Don't bother with Android, we just want the manifest.
+          project.directory.childDirectory('android').deleteSync(recursive: true);
+
+          await project.regeneratePlatformSpecificTooling();
+          expect(
+            project.flutterPluginsDependenciesFile.readAsStringSync(),
+            isNot(contains('"dev_dependency":true')),
+          );
+        },
+        overrides: <Type, Generator>{
+          FeatureFlags: enableExplicitPackageDependencies,
+          FileSystem: () => MemoryFileSystem.test(),
+          ProcessManager: () => FakeProcessManager.any(),
+          Pub: () => FakePubWithPrimedDeps(devDependencies: <String>{'my_plugin'}),
+          FlutterProjectFactory:
+              () => FlutterProjectFactory(logger: logger, fileSystem: globals.fs),
+        },
+      );
+
+      testUsingContext(
+        'specified release mode determines dev dependencies',
+        () async {
+          // Create a plugin.
+          await aPluginProject();
+          // Create a project that depends on that plugin.
+          final FlutterProject project = await projectWithPluginDependency();
+          // Don't bother with Android, we just want the manifest.
+          project.directory.childDirectory('android').deleteSync(recursive: true);
+
+          await project.regeneratePlatformSpecificTooling(releaseMode: true);
+          expect(
+            project.flutterPluginsDependenciesFile.readAsStringSync(),
+            contains('"dev_dependency":true'),
+          );
+        },
+        overrides: <Type, Generator>{
+          FeatureFlags: enableExplicitPackageDependencies,
+          FileSystem: () => MemoryFileSystem.test(),
+          ProcessManager: () => FakeProcessManager.any(),
+          Pub: () => FakePubWithPrimedDeps(devDependencies: <String>{'my_plugin'}),
+          FlutterProjectFactory:
+              () => FlutterProjectFactory(logger: logger, fileSystem: globals.fs),
+        },
+      );
+
       testUsingContext(
         'injects plugins for macOS',
         () async {
@@ -1730,6 +1789,40 @@ Future<FlutterProject> someProject({
   return FlutterProject.fromDirectory(directory);
 }
 
+Future<FlutterProject> projectWithPluginDependency() async {
+  final Directory directory = globals.fs.directory('some_project');
+  directory.childDirectory('.dart_tool').childFile('package_config.json')
+    ..createSync(recursive: true)
+    ..writeAsStringSync('''
+{
+  "configVersion": 2,
+  "packages": [
+    {
+      "name": "my_plugin",
+      "rootUri": "/plugin_project",
+      "packageUri": "lib/",
+      "languageVersion": "2.12"
+    }
+  ]
+}
+''');
+  directory.childFile('pubspec.yaml')
+    ..createSync(recursive: true)
+    ..writeAsStringSync('''
+name: app_name
+flutter:
+
+dependencies:
+  my_plugin:
+    sdk: flutter
+''');
+  directory.childDirectory('ios').createSync(recursive: true);
+  final Directory androidDirectory = directory.childDirectory('android')
+    ..createSync(recursive: true);
+  androidDirectory.childFile('AndroidManifest.xml').writeAsStringSync('<manifest></manifest>');
+  return FlutterProject.fromDirectory(directory);
+}
+
 Future<FlutterProject> aPluginProject({bool legacy = true}) async {
   final Directory directory = globals.fs.directory('plugin_project');
   directory.childDirectory('ios').createSync(recursive: true);

packages/flutter_tools/test/host_cross_arch.shard/macos_content_validation_test.dart

@@ -5,6 +5,7 @@
 import 'package:file_testing/file_testing.dart';
 import 'package:flutter_tools/src/base/file_system.dart';
 import 'package:flutter_tools/src/base/io.dart';
+import 'package:flutter_tools/src/features.dart';
 
 import '../integration.shard/test_utils.dart';
 import '../src/common.dart';
@@ -14,6 +15,20 @@ void main() {
 
   setUpAll(() {
     processManager.runSync(<String>[flutterBin, 'config', '--enable-macos-desktop']);
+
+    // TODO(matanlurey): Remove after `explicit-package-dependencies` is enabled by default.
+    // See https://github.com/flutter/flutter/issues/160257 for details.
+    if (!explicitPackageDependencies.master.enabledByDefault) {
+      processManager.runSync(<String>[flutterBin, 'config', '--explicit-package-dependencies']);
+    }
+  });
+
+  tearDownAll(() {
+    // TODO(matanlurey): Remove after `explicit-package-dependencies` is enabled by default.
+    // See https://github.com/flutter/flutter/issues/160257 for details.
+    if (!explicitPackageDependencies.master.enabledByDefault) {
+      processManager.runSync(<String>[flutterBin, 'config', '--no-explicit-package-dependencies']);
+    }
   });
 
   for (final String buildMode in <String>['Debug', 'Release']) {