firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove additional references to engine v1 android embedding (#146523)

Browse Source 
https://github.com/flutter/engine/pull/51229 blocked [the roll](https://github.com/flutter/flutter/pull/146522) and had to be reverted, which is a shame, but on the bright side it made it possible to point the framework at my removal pr, at the point of its merging the first time 

This fixes all errors that are fixable in the framework that would have blocked the roll. There are some that aren't fixable here (they need to be fixed in the engine)*, so I'll fix those in the engine but unfortunately I can't pick up another version here to re-test until I try to roll again 😢 

*This category is: uses of plugins that in turn have a `registerWith`, that references the v1 embedding. The plan to fix these cases is to leave the interface that that method relies on around for now. See https://github.com/flutter/packages/pull/6494#issuecomment-2046010323 for details
This commit is contained in:
Gray Mackall 2024-04-10 14:58:05 -07:00 committed by GitHub
parent 2ef1372aa5
commit 286c73c0eb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dev/tools/create_api_docs.dart
View File

@ -40,7 +40,7 @@ const Map<String, PlatformDocsSection> kPlatformDocs = <String, PlatformDocsSect
'android': PlatformDocsSection(
zipName: 'android-javadoc.zip',
sectionName: 'Android',
checkFile: 'io/flutter/view/FlutterView.html',
checkFile: 'io/flutter/embedding/android/FlutterView.html',
subdir: 'javadoc',
),
'ios': PlatformDocsSection(

5
packages/integration_test/android/src/main/java/dev/flutter/plugins/integration_test/IntegrationTestPlugin.java
View File

@ -30,11 +30,6 @@ public class IntegrationTestPlugin implements MethodCallHandler, FlutterPlugin,
public static final Future<Map<String, String>> testResults = testResultsSettable;
/** Plugin registration. */
@SuppressWarnings("deprecation")
public static void registerWith(io.flutter.plugin.common.PluginRegistry.Registrar registrar) {
final IntegrationTestPlugin instance = new IntegrationTestPlugin();
instance.onAttachedToEngine(registrar.context(), registrar.messenger());
}
@Override
public void onAttachedToEngine(FlutterPluginBinding binding) {