From 28f2c96a8a63ca75700b307692b3bc691d6d010c Mon Sep 17 00:00:00 2001 From: Shi-Hao Hong Date: Tue, 3 Mar 2020 13:39:01 -0800 Subject: [PATCH] AlertDialog widget scrollable by default (#49848) --- packages/flutter/lib/src/material/dialog.dart | 2 +- packages/flutter/test/material/dialog_test.dart | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/flutter/lib/src/material/dialog.dart b/packages/flutter/lib/src/material/dialog.dart index be0f638321..4a68d13c6a 100644 --- a/packages/flutter/lib/src/material/dialog.dart +++ b/packages/flutter/lib/src/material/dialog.dart @@ -259,7 +259,7 @@ class AlertDialog extends StatelessWidget { this.insetPadding = _defaultInsetPadding, this.clipBehavior = Clip.none, this.shape, - this.scrollable = false, + this.scrollable = true, }) : assert(contentPadding != null), assert(clipBehavior != null), super(key: key); diff --git a/packages/flutter/test/material/dialog_test.dart b/packages/flutter/test/material/dialog_test.dart index 2bd1161831..02e9293026 100644 --- a/packages/flutter/test/material/dialog_test.dart +++ b/packages/flutter/test/material/dialog_test.dart @@ -1100,7 +1100,6 @@ void main() { color: Colors.green, height: 1000, ), - scrollable: true, ); await tester.pumpWidget(_buildAppWithDialog(dialog)); await tester.tap(find.text('X')); @@ -1120,7 +1119,6 @@ void main() { color: Colors.orange, height: 1000, ), - scrollable: true, ); await tester.pumpWidget(_buildAppWithDialog(dialog)); await tester.tap(find.text('X')); @@ -1146,7 +1144,6 @@ void main() { color: Colors.orange, height: 400, ), - scrollable: true, ); await tester.pumpWidget(_buildAppWithDialog(dialog)); await tester.tap(find.text('X'));