firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Upload frame_request_pending_latency [attempt #2] (#135890)

Browse Source 
These values are generated since https://github.com/flutter/flutter/pull/135279, but I didn't know to add the new keys to this list to get them to upload. 

Failed to do so in #135645, I believe the mistake there was putting them in `_kCommonScoreKeys`, which is also used in "E2E" tests, that don't get full trace data, only high level `FrameTiming` packets.

Part of https://github.com/flutter/flutter/issues/129150
This commit is contained in:
Callum Moffat 2023-10-05 17:54:27 -04:00 committed by GitHub
parent 32bd280d31
commit 2925525e35
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
dev/devicelab/lib/tasks/perf_tests.dart
View File

@ -1300,6 +1300,9 @@ class PerfTest {
'average_vsync_transitions_missed', 'average_vsync_transitions_missed',
'90th_percentile_vsync_transitions_missed', '90th_percentile_vsync_transitions_missed',
'99th_percentile_vsync_transitions_missed', '99th_percentile_vsync_transitions_missed',
'average_frame_request_pending_latency',
'90th_percentile_frame_request_pending_latency',
'99th_percentile_frame_request_pending_latency',
if (measureCpuGpu && !isAndroid) ...<String>[ if (measureCpuGpu && !isAndroid) ...<String>[
// See https://github.com/flutter/flutter/issues/68888 // See https://github.com/flutter/flutter/issues/68888
if (data['average_cpu_usage'] != null) 'average_cpu_usage', if (data['average_cpu_usage'] != null) 'average_cpu_usage',

6
dev/devicelab/test/perf_tests_test.dart
View File

@ -58,6 +58,9 @@ void main() {
'average_vsync_transitions_missed': 1, 'average_vsync_transitions_missed': 1,
'90th_percentile_vsync_transitions_missed': 1, '90th_percentile_vsync_transitions_missed': 1,
'99th_percentile_vsync_transitions_missed': 1, '99th_percentile_vsync_transitions_missed': 1,
'average_frame_request_pending_latency': 0.1,
'90th_percentile_frame_request_pending_latency': 0.1,
'99th_percentile_frame_request_pending_latency': 0.1,
}; };
const String resultFileName = 'fake_result'; const String resultFileName = 'fake_result';
void driveCallback(List<String> arguments) { void driveCallback(List<String> arguments) {
@ -108,6 +111,9 @@ void main() {
'90hz_frame_percentage': 0.4, '90hz_frame_percentage': 0.4,
'120hz_frame_percentage': 0.6, '120hz_frame_percentage': 0.6,
'illegal_refresh_rate_frame_count': 10, 'illegal_refresh_rate_frame_count': 10,
'average_frame_request_pending_latency': 0.1,
'90th_percentile_frame_request_pending_latency': 0.1,
'99th_percentile_frame_request_pending_latency': 0.1,
}; };
const String resultFileName = 'fake_result'; const String resultFileName = 'fake_result';
void driveCallback(List<String> arguments) { void driveCallback(List<String> arguments) {