firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update error message for bad UTF-8 decoding (#62888)

Browse Source
This commit is contained in:
Ian Hickson 2020-08-05 14:56:14 -07:00 committed by GitHub
parent 6b7634b73a
commit 2939c209aa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/flutter_tools/lib/src/convert.dart
View File

@ -11,7 +11,10 @@ import 'base/common.dart';
export 'dart:convert' hide utf8, Utf8Codec, Utf8Decoder; export 'dart:convert' hide utf8, Utf8Codec, Utf8Decoder;
/// A [Codec] which reports malformed bytes when decoding. /// A [Codec] which reports malformed bytes when decoding.
// Created to solve https://github.com/flutter/flutter/issues/15646. ///
/// Occasionally people end up in a situation where we try to decode bytes
/// that aren't UTF-8 and we're not quite sure how this is happening.
/// This tells people to report a bug when they see this.
class Utf8Codec extends Encoding { class Utf8Codec extends Encoding {
const Utf8Codec(); const Utf8Codec();
@ -40,8 +43,9 @@ class Utf8Decoder extends cnv.Utf8Decoder {
if (reportErrors && result.contains('\u{FFFD}')) { if (reportErrors && result.contains('\u{FFFD}')) {
throwToolExit( throwToolExit(
'Bad UTF-8 encoding found while decoding string: $result. ' 'Bad UTF-8 encoding found while decoding string: $result. '
'The Flutter team would greatly appreciate if you could file a bug or leave a ' 'The Flutter team would greatly appreciate if you could file a bug explaining '
'comment on the issue https://github.com/flutter/flutter/issues/15646.\n' 'exactly what you were doing when this happened:\n'
'https://github.com/flutter/flutter/issues/new/choose\n'
'The source bytes were:\n$codeUnits\n\n'); 'The source bytes were:\n$codeUnits\n\n');
} }
return result; return result;