firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update scroll tests to use pumpUntilNoTransientCallbacks (#8495)

Browse Source 
This ensures that both timer/microtask queues are cleared out rather
than assuming that all work is completed in a specified amount of time.
This commit is contained in:
Chris Bracken 2017-03-01 10:09:29 -08:00 committed by GitHub
parent 34c63aff84
commit 297a0341a6
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter/test/material/scaffold_test.dart
View File

@ -206,7 +206,7 @@ void main() {
expect(scrollable.position.pixels, equals(500.0)); expect(scrollable.position.pixels, equals(500.0));
await tester.tapAt(const Point(100.0, 10.0)); await tester.tapAt(const Point(100.0, 10.0));
await tester.pump(); await tester.pump();
await tester.pump(const Duration(seconds: 1)); await tester.pumpUntilNoTransientCallbacks();
expect(scrollable.position.pixels, equals(0.0)); expect(scrollable.position.pixels, equals(0.0));
}); });

8
packages/flutter/test/material/tabs_test.dart
View File

@ -152,17 +152,17 @@ void main() {
await tester.tap(find.text('C')); await tester.tap(find.text('C'));
await tester.pump(); await tester.pump();
await tester.pump(const Duration(seconds: 1)); await tester.pumpUntilNoTransientCallbacks();
expect(controller.index, 2); expect(controller.index, 2);
await tester.tap(find.text('B')); await tester.tap(find.text('B'));
await tester.pump(); await tester.pump();
await tester.pump(const Duration(seconds: 1)); await tester.pumpUntilNoTransientCallbacks();
expect(controller.index, 1); expect(controller.index, 1);
await tester.tap(find.text('A')); await tester.tap(find.text('A'));
await tester.pump(); await tester.pump();
await tester.pump(const Duration(seconds: 1)); await tester.pumpUntilNoTransientCallbacks();
expect(controller.index, 0); expect(controller.index, 0);
}); });
@ -180,7 +180,7 @@ void main() {
await tester.tap(find.text('FFFFFF')); await tester.tap(find.text('FFFFFF'));
await tester.pump(); await tester.pump();
await tester.pump(const Duration(seconds: 1)); // finish the scroll animation await tester.pumpUntilNoTransientCallbacks();
expect(controller.index, 5); expect(controller.index, 5);
// The center of the FFFFFF item is now at the TabBar's center // The center of the FFFFFF item is now at the TabBar's center
expect(tester.getCenter(find.text('FFFFFF')).x, closeTo(400.0, 1.0)); expect(tester.getCenter(find.text('FFFFFF')).x, closeTo(400.0, 1.0));

2
packages/flutter/test/widgets/state_setting_in_scrollables_test.dart
View File

@ -83,7 +83,7 @@ void main() {
expect(tester.state<ScrollableState>(find.byType(Scrollable)).position.pixels, 0.0); expect(tester.state<ScrollableState>(find.byType(Scrollable)).position.pixels, 0.0);
await tester.tap(find.byType(GestureDetector).first); await tester.tap(find.byType(GestureDetector).first);
await tester.pump(); await tester.pump();
await tester.pump(const Duration(seconds: 1)); await tester.pumpUntilNoTransientCallbacks();
expect(tester.state<ScrollableState>(find.byType(Scrollable)).position.pixels, 200.0); expect(tester.state<ScrollableState>(find.byType(Scrollable)).position.pixels, 200.0);
}); });
} }