firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix microbenchmarks tests. (#9782)

Browse Source
This commit is contained in:
Ian Hickson 2017-05-03 17:33:29 -07:00 committed by GitHub
parent 961da5a3bc
commit 2b04e300af
3 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dev/benchmarks/microbenchmarks/lib/stocks/build_bench.dart
View File

@ -44,7 +44,11 @@ Future<Null> main() async {
// artificially high load to find out how much CPU each frame takes. // artificially high load to find out how much CPU each frame takes.
// This differs from normal benchmarks which might look at how many // This differs from normal benchmarks which might look at how many
// frames are missed, etc. // frames are missed, etc.
ui.window.onBeginFrame(new Duration(milliseconds: iterations * 16)); // We use Timer.run to ensure there's a microtask flush in between
// the two calls below.
Timer.run(() { ui.window.onBeginFrame(new Duration(milliseconds: iterations * 16)); });
Timer.run(() { ui.window.onDrawFrame(); });
await tester.idle(); // wait until the frame has run
iterations += 1; iterations += 1;
} }
watch.stop(); watch.stop();

6
dev/benchmarks/microbenchmarks/lib/stocks/layout_bench.dart
View File

@ -45,7 +45,11 @@ Future<Null> main() async {
// artificially high load to find out how much CPU each frame takes. // artificially high load to find out how much CPU each frame takes.
// This differs from normal benchmarks which might look at how many // This differs from normal benchmarks which might look at how many
// frames are missed, etc. // frames are missed, etc.
ui.window.onBeginFrame(new Duration(milliseconds: iterations * 16)); // We use Timer.run to ensure there's a microtask flush in between
// the two calls below.
Timer.run(() { ui.window.onBeginFrame(new Duration(milliseconds: iterations * 16)); });
Timer.run(() { ui.window.onDrawFrame(); });
await tester.idle(); // wait until the frame has run
iterations += 1; iterations += 1;
} }
watch.stop(); watch.stop();

3
dev/devicelab/lib/tasks/microbenchmarks.dart
View File

@ -29,9 +29,8 @@ TaskFunction createMicrobenchmarkTask() {
final Directory appDir = dir( final Directory appDir = dir(
path.join(flutterDirectory.path, 'dev/benchmarks/microbenchmarks')); path.join(flutterDirectory.path, 'dev/benchmarks/microbenchmarks'));
final Process flutterProcess = await inDirectory(appDir, () async { final Process flutterProcess = await inDirectory(appDir, () async {
if (deviceOperatingSystem == DeviceOperatingSystem.ios) { if (deviceOperatingSystem == DeviceOperatingSystem.ios)
await prepareProvisioningCertificates(appDir.path); await prepareProvisioningCertificates(appDir.path);
}
return await _startFlutter( return await _startFlutter(
options: <String>[ options: <String>[
'--profile', '--profile',