firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Mark routing test as leaking. (#133697)

Browse Source
This commit is contained in:
Polina Cherkasova 2023-08-30 16:25:18 -07:00 committed by GitHub
parent 784629c938
commit 2bc4c7a888
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/flutter/test/material/app_test.dart
View File

@ -57,7 +57,7 @@ void main() {
expect(focusNode.hasFocus, isTrue); expect(focusNode.hasFocus, isTrue);
}); });
testWidgets('Can place app inside FocusScope', (WidgetTester tester) async { testWidgetsWithLeakTracking('Can place app inside FocusScope', (WidgetTester tester) async {
final FocusScopeNode focusScopeNode = FocusScopeNode(); final FocusScopeNode focusScopeNode = FocusScopeNode();
await tester.pumpWidget(FocusScope( await tester.pumpWidget(FocusScope(
@ -69,6 +69,7 @@ void main() {
)); ));
expect(find.text('Home'), findsOneWidget); expect(find.text('Home'), findsOneWidget);
focusScopeNode.dispose();
}); });
testWidgetsWithLeakTracking('Can show grid without losing sync', (WidgetTester tester) async { testWidgetsWithLeakTracking('Can show grid without losing sync', (WidgetTester tester) async {
@ -310,7 +311,7 @@ void main() {
expect(find.text('route "/b"', skipOffstage: false), findsNothing); expect(find.text('route "/b"', skipOffstage: false), findsNothing);
}); });
testWidgets('Initial route with missing step', (WidgetTester tester) async { testWidgetsWithLeakTracking('Initial route with missing step', (WidgetTester tester) async {
final Map<String, WidgetBuilder> routes = <String, WidgetBuilder>{ final Map<String, WidgetBuilder> routes = <String, WidgetBuilder>{
'/': (BuildContext context) => const Text('route "/"'), '/': (BuildContext context) => const Text('route "/"'),
'/a': (BuildContext context) => const Text('route "/a"'), '/a': (BuildContext context) => const Text('route "/a"'),
@ -333,7 +334,12 @@ void main() {
expect(find.text('route "/a/b"'), findsNothing); expect(find.text('route "/a/b"'), findsNothing);
expect(find.text('route "/b"'), findsNothing); expect(find.text('route "/b"'), findsNothing);
} }
}); },
// TODO(polina-c): remove after fixing
// https://github.com/flutter/flutter/issues/133695
leakTrackingTestConfig: const LeakTrackingTestConfig(
notDisposedAllowList: <String, int?> {'ValueNotifier<String?>': 3},
));
testWidgetsWithLeakTracking('Make sure initialRoute is only used the first time', (WidgetTester tester) async { testWidgetsWithLeakTracking('Make sure initialRoute is only used the first time', (WidgetTester tester) async {
final Map<String, WidgetBuilder> routes = <String, WidgetBuilder>{ final Map<String, WidgetBuilder> routes = <String, WidgetBuilder>{