firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

showDialog assertion for non-null builder or child property (#71838)

Browse Source
This commit is contained in:
Amit Patil 2020-12-08 22:33:03 +05:30 committed by GitHub
parent 995aa138cd
commit 2cb652600c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 52 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/flutter/lib/src/material/dialog.dart
View File

@ -973,6 +973,7 @@ Future<T?> showDialog<T>({
Widget? child,
}) {
assert(child == null || builder == null);
assert(child != null || builder != null);
assert(barrierDismissible != null);
assert(useSafeArea != null);
assert(useRootNavigator != null);

51
packages/flutter/test/material/dialog_test.dart
View File

@ -217,6 +217,57 @@ void main() {
expect(materialWidget.shape, customBorder);
});
testWidgets('showDialog child and builder cannot be simultaneously defined', (WidgetTester tester) async {
late BuildContext currentBuildContext;
await tester.pumpWidget(
MaterialApp(
home: Scaffold(
body: Center(
child: Builder(
builder: (BuildContext context) {
currentBuildContext = context;
return Container();
}
),
),
),
),
);
expect(() async {
showDialog<void>(
context: currentBuildContext,
child: const Text('Child'),
builder: (BuildContext context) {
return const Text('Builder');
},
);
}, throwsAssertionError);
});
testWidgets('showDialog child or builder must be defined', (WidgetTester tester) async {
late BuildContext currentBuildContext;
await tester.pumpWidget(
MaterialApp(
home: Scaffold(
body: Center(
child: Builder(
builder: (BuildContext context) {
currentBuildContext = context;
return Container();
}
),
),
),
),
);
expect(
() => showDialog<void>(context: currentBuildContext),
throwsAssertionError,
);
});
testWidgets('Simple dialog control test', (WidgetTester tester) async {
await tester.pumpWidget(
const MaterialApp(