From 2ce743d0f0a0d73f3a2b051cbcd0a15faa9563e1 Mon Sep 17 00:00:00 2001 From: Matan Lurey Date: Fri, 1 Nov 2024 12:20:59 -0700 Subject: [PATCH] Remove unnecessary `kCliAnimationsFeatureName` that is available as `.configSetting`. (#158013) ... for consistency with the rest of the file/features. --- packages/flutter_tools/lib/src/features.dart | 4 +--- .../test/general.shard/reporting/first_run_test.dart | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/flutter_tools/lib/src/features.dart b/packages/flutter_tools/lib/src/features.dart index 62cd4dc02c..7c86574bc8 100644 --- a/packages/flutter_tools/lib/src/features.dart +++ b/packages/flutter_tools/lib/src/features.dart @@ -146,14 +146,12 @@ const Feature flutterCustomDevicesFeature = Feature( ), ); -const String kCliAnimationsFeatureName = 'cli-animations'; - /// The [Feature] for CLI animations. /// /// The TERM environment variable set to "dumb" turns this off. const Feature cliAnimation = Feature.fullyEnabled( name: 'animations in the command line interface', - configSetting: kCliAnimationsFeatureName, + configSetting: 'cli-animations', ); /// Enable native assets compilation and bundling. diff --git a/packages/flutter_tools/test/general.shard/reporting/first_run_test.dart b/packages/flutter_tools/test/general.shard/reporting/first_run_test.dart index 95af4a90d7..e4f1008b3b 100644 --- a/packages/flutter_tools/test/general.shard/reporting/first_run_test.dart +++ b/packages/flutter_tools/test/general.shard/reporting/first_run_test.dart @@ -20,7 +20,7 @@ void main() { testWithoutContext('FirstRunMessenger informs user how to disable animations', () { final FirstRunMessenger messenger = setUpFirstRunMessenger(redisplayWelcomeMessage: false); - expect(messenger.licenseTerms, contains('flutter config --no-$kCliAnimationsFeatureName')); + expect(messenger.licenseTerms, contains('flutter config --no-${cliAnimation.configSetting}')); }); testWithoutContext('FirstRunMessenger requires redisplay if it has never been run before', () {