firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[iOS] Fix naming in platform_view example (#144247)

Browse Source 
This applies minor cosmetic cleanups noticed while landing fix/tests in another patch. Renames `incrementLabel` to `countLabel` and `setIncrementLabel` to `updateCountLabel`, since it's not setting it to a specific value but rather updating itself based on the current state of the `count` ivar.

No tests since this patch introduces no semantic changes.

Related: https://github.com/flutter/flutter/pull/132028
This commit is contained in:
Chris Bracken 2024-02-27 14:49:09 -08:00 committed by GitHub
parent 2eee0b5750
commit 2e4bbb7503
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
examples/platform_view/ios/Runner/Base.lproj/Main.storyboard
View File

@ -129,7 +129,7 @@
</constraints> </constraints>
</view> </view>
<connections> <connections>
<outlet property="incrementLabel" destination="qaB-rs-mWp" id="bFY-of-WoI"/> <outlet property="countLabel" destination="qaB-rs-mWp" id="bFY-of-WoI"/>
<outlet property="incrementButton" destination="6yL-sX-bUL" id="aQR-ap-BrT"/> <outlet property="incrementButton" destination="6yL-sX-bUL" id="aQR-ap-BrT"/>
</connections> </connections>
</viewController> </viewController>

10
examples/platform_view/ios/Runner/PlatformViewController.m
View File

@ -7,19 +7,19 @@
#import <Foundation/Foundation.h> #import <Foundation/Foundation.h>
@interface PlatformViewController () @interface PlatformViewController ()
@property(weak, nonatomic) IBOutlet UILabel* incrementLabel; @property(weak, nonatomic) IBOutlet UILabel* countLabel;
@end @end
@implementation PlatformViewController @implementation PlatformViewController
- (void)viewDidLoad { - (void)viewDidLoad {
[super viewDidLoad]; [super viewDidLoad];
[self setIncrementLabelText]; [self updateCountLabelText];
} }
- (IBAction)handleIncrement:(id)sender { - (IBAction)handleIncrement:(id)sender {
self.counter++; self.counter++;
[self setIncrementLabelText]; [self updateCountLabelText];
} }
- (IBAction)switchToFlutterView:(id)sender { - (IBAction)switchToFlutterView:(id)sender {
@ -27,10 +27,10 @@
[self dismissViewControllerAnimated:NO completion:nil]; [self dismissViewControllerAnimated:NO completion:nil];
} }
- (void)setIncrementLabelText { - (void)updateCountLabelText {
NSString* text = [NSString stringWithFormat:@"Button tapped %d %@.", self.counter, NSString* text = [NSString stringWithFormat:@"Button tapped %d %@.", self.counter,
(self.counter == 1) ? @"time" : @"times"]; (self.counter == 1) ? @"time" : @"times"];
self.incrementLabel.text = text; self.countLabel.text = text;
} }
@end @end