firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Readability revisions for #109891 (#110348)

Browse Source
This commit is contained in:
Stephen (Alex) Wallen 2022-08-29 11:23:16 -07:00 committed by GitHub
parent 047cb86453
commit 2f3ba1a313
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
dev/devicelab/lib/tasks/perf_tests.dart
View File

@ -1425,18 +1425,19 @@ class CompileTest {
cwd, cwd,
'build', 'build',
)); ));
final String? appBundlePath = final String? appPath =
_findDarwinAppInBuildDirectory(buildDirectory.path); _findDarwinAppInBuildDirectory(buildDirectory.path);
if (appBundlePath == null) { if (appPath == null) {
throw 'Failed to find app bundle in ${buildDirectory.path}'; throw 'Failed to find app bundle in ${buildDirectory.path}';
} }
// IPAs are created manually, https://flutter.dev/ios-release/ // Validate changes in Dart snapshot format and data layout do not
await exec('tar', <String>['-zcf', 'build/app.ipa', appBundlePath]); // change compression size. This also simulates the size of an IPA on iOS.
releaseSizeInBytes = await file('$cwd/build/app.ipa').length(); await exec('tar', <String>['-zcf', 'build/app.tar.gz', appPath]);
releaseSizeInBytes = await file('$cwd/build/app.tar.gz').length();
if (reportPackageContentSizes) { if (reportPackageContentSizes) {
final Map<String, Object> sizeMetrics = await getSizesFromDarwinApp( final Map<String, Object> sizeMetrics = await getSizesFromDarwinApp(
appPath: appBundlePath, appPath: appPath,
operatingSystem: deviceOperatingSystem, operatingSystem: deviceOperatingSystem,
); );
metrics.addAll(sizeMetrics); metrics.addAll(sizeMetrics);
} }