firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Impeller] Require the GLES multisampled_render_to_texture2 extension for offscreen MSAA (flutter/engine#56997)

Browse Source 
Offscreen MSAA needs the ability to create multisample depth and stencil attachments.
This commit is contained in:
Jason Simmons 2024-12-06 07:43:23 -08:00 committed by GitHub
parent e9540f935e
commit 30289be8ba
2 changed files with 21 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
engine/src/flutter/impeller/renderer/backend/gles/capabilities_gles.cc
View File

@ -22,6 +22,10 @@ static const constexpr char* kNvidiaTextureBorderClampExt =
static const constexpr char* kMultisampledRenderToTextureExt = static const constexpr char* kMultisampledRenderToTextureExt =
"GL_EXT_multisampled_render_to_texture"; "GL_EXT_multisampled_render_to_texture";
// https://registry.khronos.org/OpenGL/extensions/EXT/EXT_multisampled_render_to_texture2.txt
static const constexpr char* kMultisampledRenderToTexture2Ext =
"GL_EXT_multisampled_render_to_texture2";
CapabilitiesGLES::CapabilitiesGLES(const ProcTableGLES& gl) { CapabilitiesGLES::CapabilitiesGLES(const ProcTableGLES& gl) {
{ {
GLint value = 0; GLint value = 0;
@ -123,11 +127,13 @@ CapabilitiesGLES::CapabilitiesGLES(const ProcTableGLES& gl) {
if (desc->HasExtension(kMultisampledRenderToTextureExt)) { if (desc->HasExtension(kMultisampledRenderToTextureExt)) {
supports_implicit_msaa_ = true; supports_implicit_msaa_ = true;
if (desc->HasExtension(kMultisampledRenderToTexture2Ext)) {
// We hard-code 4x MSAA, so let's make sure it's supported. // We hard-code 4x MSAA, so let's make sure it's supported.
GLint value = 0; GLint value = 0;
gl.GetIntegerv(GL_MAX_SAMPLES_EXT, &value); gl.GetIntegerv(GL_MAX_SAMPLES_EXT, &value);
supports_offscreen_msaa_ = value >= 4; supports_offscreen_msaa_ = value >= 4;
} }
}
is_es_ = desc->IsES(); is_es_ = desc->IsES();
is_angle_ = desc->IsANGLE(); is_angle_ = desc->IsANGLE();
} }

11
engine/src/flutter/impeller/renderer/backend/gles/test/capabilities_unittests.cc
View File

@ -63,5 +63,16 @@ TEST(CapabilitiesGLES, SupportsFramebufferFetch) {
EXPECT_TRUE(capabilities->SupportsFramebufferFetch()); EXPECT_TRUE(capabilities->SupportsFramebufferFetch());
} }
TEST(CapabilitiesGLES, SupportsMSAA) {
auto const extensions = std::vector<const unsigned char*>{
reinterpret_cast<const unsigned char*>(
"GL_EXT_multisampled_render_to_texture"),
};
auto mock_gles = MockGLES::Init(extensions);
auto capabilities = mock_gles->GetProcTable().GetCapabilities();
EXPECT_TRUE(capabilities->SupportsImplicitResolvingMSAA());
EXPECT_FALSE(capabilities->SupportsOffscreenMSAA());
}
} // namespace testing } // namespace testing
} // namespace impeller } // namespace impeller