firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Re-enable Gold post-submit fail state (#101528)

Browse Source
This commit is contained in:
Kate Lovett 2022-04-07 17:36:09 -05:00 committed by GitHub
parent 012952ba47
commit 324e6d9d4e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 39 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

78
packages/flutter_goldens/test/flutter_goldens_test.dart
View File

@ -257,46 +257,44 @@ void main() {
await skiaClient.tryjobInit();
});
// TODO(Piinks): Re-enable once https://github.com/flutter/flutter/issues/100304
// is resolved.
// test('throws for error state from imgtestAdd', () {
// final File goldenFile = fs.file('/workDirectory/temp/golden_file_test.png')
// ..createSync(recursive: true);
// platform = FakePlatform(
// environment: <String, String>{
// 'FLUTTER_ROOT': _kFlutterRoot,
// 'GOLDCTL' : 'goldctl',
// },
// operatingSystem: 'macos'
// );
//
// skiaClient = SkiaGoldClient(
// workDirectory,
// fs: fs,
// process: process,
// platform: platform,
// httpClient: fakeHttpClient,
// );
//
// const RunInvocation goldctlInvocation = RunInvocation(
// <String>[
// 'goldctl',
// 'imgtest', 'add',
// '--work-dir', '/workDirectory/temp',
// '--test-name', 'golden_file_test',
// '--png-file', '/workDirectory/temp/golden_file_test.png',
// '--passfail',
// ],
// null,
// );
// process.processResults[goldctlInvocation] = ProcessResult(123, 1, 'Expected failure', 'Expected failure');
// process.fallbackProcessResult = ProcessResult(123, 1, 'Fallback failure', 'Fallback failure');
//
// expect(
// skiaClient.imgtestAdd('golden_file_test', goldenFile),
// throwsException,
// );
// });
test('throws for error state from imgtestAdd', () {
final File goldenFile = fs.file('/workDirectory/temp/golden_file_test.png')
..createSync(recursive: true);
platform = FakePlatform(
environment: <String, String>{
'FLUTTER_ROOT': _kFlutterRoot,
'GOLDCTL' : 'goldctl',
},
operatingSystem: 'macos'
);
skiaClient = SkiaGoldClient(
workDirectory,
fs: fs,
process: process,
platform: platform,
httpClient: fakeHttpClient,
);
const RunInvocation goldctlInvocation = RunInvocation(
<String>[
'goldctl',
'imgtest', 'add',
'--work-dir', '/workDirectory/temp',
'--test-name', 'golden_file_test',
'--png-file', '/workDirectory/temp/golden_file_test.png',
'--passfail',
],
null,
);
process.processResults[goldctlInvocation] = ProcessResult(123, 1, 'Expected failure', 'Expected failure');
process.fallbackProcessResult = ProcessResult(123, 1, 'Fallback failure', 'Fallback failure');
expect(
skiaClient.imgtestAdd('golden_file_test', goldenFile),
throwsException,
);
});
test('correctly inits tryjob for luci', () async {
platform = FakePlatform(

7
packages/flutter_goldens_client/lib/skia_client.dart
View File

@ -212,12 +212,7 @@ class SkiaGoldClient {
..writeln('Debug information for Gold:')
..writeln('stdout: ${result.stdout}')
..writeln('stderr: ${result.stderr}');
// Temporarily print logs for issue diagnosis
// ignore: avoid_print
print(buf.toString());
// TODO(Piinks): Re-enable once https://github.com/flutter/flutter/issues/100304
// is resolved.
// throw Exception(buf.toString());
throw Exception(buf.toString());
}
return true;