firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fixes for incoming linter (#113794)

Browse Source 
* fixes for incomming linter

* + todo

* todo format fix

* justify ignore

* --
This commit is contained in:
Phil Quitslund 2022-11-03 10:56:59 -07:00 committed by GitHub
parent a440c4689f
commit 33b81ed954
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/flutter/lib/src/material/menu_anchor.dart
View File

@ -483,7 +483,7 @@ class _MenuAnchorState extends State<MenuAnchor> {
// close it first. // close it first.
_close(); _close();
} }
assert(_debugMenuInfo('Opening ${this} at ${position ?? Offset.zero} with alignment offset ${widget.alignmentOffset ?? Offset.zero}')); assert(_debugMenuInfo('Opening $this at ${position ?? Offset.zero} with alignment offset ${widget.alignmentOffset ?? Offset.zero}'));
_parent?._closeChildren(); // Close all siblings. _parent?._closeChildren(); // Close all siblings.
assert(_overlayEntry == null); assert(_overlayEntry == null);
@ -553,6 +553,8 @@ class _MenuAnchorState extends State<MenuAnchor> {
} }
void _closeChildren({bool inDispose = false}) { void _closeChildren({bool inDispose = false}) {
// TODO(pquitslund): remove when interpolated `$this` parsing is fixed (https://github.com/dart-lang/sdk/issues/50263)
// ignore: unnecessary_brace_in_string_interps
assert(_debugMenuInfo('Closing children of ${this}${inDispose ? ' (dispose)' : ''}')); assert(_debugMenuInfo('Closing children of ${this}${inDispose ? ' (dispose)' : ''}'));
for (final _MenuAnchorState child in List<_MenuAnchorState>.from(_anchorChildren)) { for (final _MenuAnchorState child in List<_MenuAnchorState>.from(_anchorChildren)) {
child._close(inDispose: inDispose); child._close(inDispose: inDispose);

3
packages/flutter/lib/src/widgets/layout_builder.dart
View File

@ -269,9 +269,6 @@ class LayoutBuilder extends ConstrainedLayoutBuilder<BoxConstraints> {
required super.builder, required super.builder,
}) : assert(builder != null); }) : assert(builder != null);
@override
LayoutWidgetBuilder get builder => super.builder;
@override @override
RenderObject createRenderObject(BuildContext context) => _RenderLayoutBuilder(); RenderObject createRenderObject(BuildContext context) => _RenderLayoutBuilder();
} }

6
packages/flutter/lib/src/widgets/sliver_layout_builder.dart
View File

@ -32,12 +32,6 @@ class SliverLayoutBuilder extends ConstrainedLayoutBuilder<SliverConstraints> {
required super.builder, required super.builder,
}); });
/// Called at layout time to construct the widget tree.
///
/// The builder must return a non-null sliver widget.
@override
SliverLayoutWidgetBuilder get builder => super.builder;
@override @override
RenderObject createRenderObject(BuildContext context) => _RenderSliverLayoutBuilder(); RenderObject createRenderObject(BuildContext context) => _RenderSliverLayoutBuilder();
} }

1
packages/flutter_test/lib/src/test_compat.dart
View File

@ -34,6 +34,7 @@ Declarer get _declarer {
Future<void>(() { Future<void>(() {
Invoker.guard<Future<void>>(() async { Invoker.guard<Future<void>>(() async {
final _Reporter reporter = _Reporter(color: false); // disable color when run directly. final _Reporter reporter = _Reporter(color: false); // disable color when run directly.
// ignore: recursive_getters, this self-call is safe since it will just fetch the declarer instance
final Group group = _declarer.build(); final Group group = _declarer.build();
final Suite suite = Suite(group, SuitePlatform(Runtime.vm)); final Suite suite = Suite(group, SuitePlatform(Runtime.vm));
await _runGroup(suite, group, <Group>[], reporter); await _runGroup(suite, group, <Group>[], reporter);