firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[macos] build: add build-number and buid-name arguments (#53928)

Browse Source
This commit is contained in:
Herbert Poul 2020-04-11 22:20:01 +02:00 committed by GitHub
parent 35ed1ccc9a
commit 3441743c5c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 30 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter_tools/lib/src/commands/build_macos.dart
View File

@ -23,6 +23,8 @@ class BuildMacosCommand extends BuildSubCommand {
addBuildModeFlags();
addDartObfuscationOption();
usesExtraFrontendOptions();
usesBuildNumberOption();
usesBuildNameOption();
}
@override

28
packages/flutter_tools/test/commands.shard/hermetic/build_macos_test.dart
View File

@ -211,6 +211,34 @@ void main() {
FeatureFlags: () => TestFeatureFlags(isMacOSEnabled: true),
});
testUsingContext('macOS build supports build-name and build-number', () async {
final BuildCommand command = BuildCommand();
createMinimalMockProjectFiles();
await createTestCommandRunner(command).run(
const <String>[
'build',
'macos',
'--debug',
'--build-name=1.2.3',
'--build-number=42',
],
);
final String contents = fileSystem
.file('./macos/Flutter/ephemeral/Flutter-Generated.xcconfig')
.readAsStringSync();
expect(contents, contains('FLUTTER_BUILD_NAME=1.2.3'));
expect(contents, contains('FLUTTER_BUILD_NUMBER=42'));
}, overrides: <Type, Generator>{
FileSystem: () => fileSystem,
ProcessManager: () => FakeProcessManager.list(<FakeCommand>[
setUpMockXcodeBuildHandler('Debug')
]),
Platform: () => macosPlatform,
FeatureFlags: () => TestFeatureFlags(isMacOSEnabled: true),
});
testUsingContext('Refuses to build for macOS when feature is disabled', () {
final CommandRunner<void> runner = createTestCommandRunner(BuildCommand());