firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove redundant rootDirectoryPath parameter in DevFS::update (#143034)

Browse Source 
Resolves #143041
This commit is contained in:
Andrew Kolos 2024-02-07 10:04:31 -08:00 committed by GitHub
parent 8e2da8414c
commit 34c2080b9d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/flutter_tools/lib/src/devfs.dart
View File

@ -570,7 +570,6 @@ class DevFS {
DateTime? firstBuildTime, DateTime? firstBuildTime,
bool bundleFirstUpload = false, bool bundleFirstUpload = false,
bool fullRestart = false, bool fullRestart = false,
String? projectRootPath,
File? dartPluginRegistrant, File? dartPluginRegistrant,
}) async { }) async {
final DateTime candidateCompileTime = DateTime.now(); final DateTime candidateCompileTime = DateTime.now();
@ -598,7 +597,7 @@ class DevFS {
invalidatedFiles, invalidatedFiles,
outputPath: dillOutputPath, outputPath: dillOutputPath,
fs: _fileSystem, fs: _fileSystem,
projectRootPath: projectRootPath, projectRootPath: rootDirectory?.path,
packageConfig: packageConfig, packageConfig: packageConfig,
checkDartPluginRegistry: true, // The entry point is assumed not to have changed. checkDartPluginRegistry: true, // The entry point is assumed not to have changed.
dartPluginRegistrant: dartPluginRegistrant, dartPluginRegistrant: dartPluginRegistrant,

1
packages/flutter_tools/lib/src/isolated/resident_web_runner.dart
View File

@ -569,7 +569,6 @@ Please provide a valid TCP port (an integer between 0 and 65535, inclusive).
generator: device!.generator!, generator: device!.generator!,
fullRestart: fullRestart, fullRestart: fullRestart,
dillOutputPath: dillOutputPath, dillOutputPath: dillOutputPath,
projectRootPath: projectRootPath,
pathToReload: getReloadPath(fullRestart: fullRestart, swap: false), pathToReload: getReloadPath(fullRestart: fullRestart, swap: false),
invalidatedFiles: invalidationResult.uris!, invalidatedFiles: invalidationResult.uris!,
packageConfig: invalidationResult.packageConfig!, packageConfig: invalidationResult.packageConfig!,

2
packages/flutter_tools/lib/src/resident_runner.dart
View File

@ -560,7 +560,6 @@ class FlutterDevice {
bool bundleFirstUpload = false, bool bundleFirstUpload = false,
bool bundleDirty = false, bool bundleDirty = false,
bool fullRestart = false, bool fullRestart = false,
String? projectRootPath,
required String pathToReload, required String pathToReload,
required String dillOutputPath, required String dillOutputPath,
required List<Uri> invalidatedFiles, required List<Uri> invalidatedFiles,
@ -581,7 +580,6 @@ class FlutterDevice {
fullRestart: fullRestart, fullRestart: fullRestart,
dillOutputPath: dillOutputPath, dillOutputPath: dillOutputPath,
trackWidgetCreation: buildInfo.trackWidgetCreation, trackWidgetCreation: buildInfo.trackWidgetCreation,
projectRootPath: projectRootPath,
pathToReload: pathToReload, pathToReload: pathToReload,
invalidatedFiles: invalidatedFiles, invalidatedFiles: invalidatedFiles,
packageConfig: packageConfig, packageConfig: packageConfig,

1
packages/flutter_tools/lib/src/run_hot.dart
View File

@ -542,7 +542,6 @@ class HotRunner extends ResidentRunner {
bundleFirstUpload: isFirstUpload, bundleFirstUpload: isFirstUpload,
bundleDirty: !isFirstUpload && rebuildBundle, bundleDirty: !isFirstUpload && rebuildBundle,
fullRestart: fullRestart, fullRestart: fullRestart,
projectRootPath: projectRootPath,
pathToReload: getReloadPath(fullRestart: fullRestart, swap: _swap), pathToReload: getReloadPath(fullRestart: fullRestart, swap: _swap),
invalidatedFiles: invalidationResult.uris!, invalidatedFiles: invalidationResult.uris!,
packageConfig: invalidationResult.packageConfig!, packageConfig: invalidationResult.packageConfig!,