From 35c364053bd3db906a6c9f9bd85745943e5fc5bf Mon Sep 17 00:00:00 2001 From: Jonah Williams Date: Thu, 15 Oct 2020 19:03:28 -0700 Subject: [PATCH] Fix screenshotting code (#68261) --- dev/devicelab/lib/framework/utils.dart | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dev/devicelab/lib/framework/utils.dart b/dev/devicelab/lib/framework/utils.dart index e60753c281..ad29d3f2b6 100644 --- a/dev/devicelab/lib/framework/utils.dart +++ b/dev/devicelab/lib/framework/utils.dart @@ -280,12 +280,12 @@ Future startProcess( final String finalWorkingDirectory = workingDirectory ?? cwd; print('\nExecuting: $command in $finalWorkingDirectory' + (environment != null ? ' with environment $environment' : '')); - environment ??= {}; - environment['BOT'] = isBot ? 'true' : 'false'; - environment['FLUTTER_IOS_SCREENSHOT_ON_CONNECTION_FAILURE'] = 'true'; + final Map newEnvironment = Map.from(environment ?? {}); + newEnvironment['BOT'] = isBot ? 'true' : 'false'; + newEnvironment['FLUTTER_IOS_SCREENSHOT_ON_CONNECTION_FAILURE'] = 'true'; final Process process = await _processManager.start( [executable, ...arguments], - environment: environment, + environment: newEnvironment, workingDirectory: finalWorkingDirectory, ); final ProcessInfo processInfo = ProcessInfo(command, process);