firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixing patch for coming breaking change in HttpClientRequest (#61138)

Browse Source 
* Fixing patch for coming breaking change in HttpClientRequest

* Add noSuchMethod() and comment out abort()

* Add ignore: override_on_non_overriding_member
This commit is contained in:
zichangg 2020-07-15 10:07:57 -07:00 committed by GitHub
parent 6e0bc30e84
commit 3631adc99a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/flutter_test/lib/src/_binding_io.dart
View File

@ -228,6 +228,11 @@ class _MockHttpRequest extends HttpClientRequest {
return Future<HttpClientResponse>.value(_MockHttpResponse()); return Future<HttpClientResponse>.value(_MockHttpResponse());
} }
// TODO(zichangguo): remove the ignore after the change in dart:io lands.
@override
// ignore: override_on_non_overriding_member
void abort([Object exception, StackTrace stackTrace]) {}
@override @override
HttpConnectionInfo get connectionInfo => null; HttpConnectionInfo get connectionInfo => null;

5
packages/flutter_tools/test/src/testbed.dart
View File

@ -377,6 +377,11 @@ class FakeHttpClientRequest implements HttpClientRequest {
@override @override
void writeln([Object obj = '']) {} void writeln([Object obj = '']) {}
// TODO(zichangguo): remove the ignore after the change in dart:io lands.
@override
// ignore: override_on_non_overriding_member
void abort([Object exception, StackTrace stackTrace]) {}
} }
class FakeHttpClientResponse implements HttpClientResponse { class FakeHttpClientResponse implements HttpClientResponse {