From 3635a3048e8b8d072aab1e288cde607aecd308d5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Sharma?= <737941+loic-sharma@users.noreply.github.com> Date: Fri, 17 Mar 2023 14:29:12 -0700 Subject: [PATCH] Revert "[Tool] [Windows] Output app path on build completion (#122858)" (#122926) Revert "[Tool] [Windows] Output app path on build completion" --- dev/devicelab/lib/tasks/run_tests.dart | 22 ------------------- .../lib/src/windows/build_windows.dart | 17 -------------- 2 files changed, 39 deletions(-) diff --git a/dev/devicelab/lib/tasks/run_tests.dart b/dev/devicelab/lib/tasks/run_tests.dart index f7a41169e3..9dc6b3df61 100644 --- a/dev/devicelab/lib/tasks/run_tests.dart +++ b/dev/devicelab/lib/tasks/run_tests.dart @@ -177,9 +177,6 @@ class WindowsRunOutputTest extends DesktopRunOutputTest { r'Building Windows application\.\.\.\s*\d+(\.\d+)?(ms|s)', multiLine: true, ); - static final RegExp _builtOutput = RegExp( - r'Built build\\windows\\runner\\(Debug|Release)\\\w+\.exe( \(\d+(\.\d+)?MB\))?\.', - ); @override void verifyBuildOutput(List stdout) { @@ -188,25 +185,6 @@ class WindowsRunOutputTest extends DesktopRunOutputTest { _buildOutput.hasMatch, 'Building Windows application...', ); - - final String buildMode = release ? 'Release' : 'Debug'; - _findNextMatcherInList( - stdout, - (String line) { - if (!_builtOutput.hasMatch(line) || !line.contains(buildMode)) { - return false; - } - - // Size information is only included in release builds. - final bool hasSize = line.contains('MB).'); - if (release != hasSize) { - return false; - } - - return true; - }, - 'Built build\\windows\\runner\\$buildMode\\app.exe', - ); } } diff --git a/packages/flutter_tools/lib/src/windows/build_windows.dart b/packages/flutter_tools/lib/src/windows/build_windows.dart index 5df9fe7827..c0a01b4b11 100644 --- a/packages/flutter_tools/lib/src/windows/build_windows.dart +++ b/packages/flutter_tools/lib/src/windows/build_windows.dart @@ -8,7 +8,6 @@ import '../base/common.dart'; import '../base/file_system.dart'; import '../base/logger.dart'; import '../base/project_migrator.dart'; -import '../base/terminal.dart'; import '../base/utils.dart'; import '../build_info.dart'; import '../cache.dart'; @@ -93,22 +92,6 @@ Future buildWindows(WindowsProject windowsProject, BuildInfo buildInfo, { } finally { status.stop(); } - - final File appFile = buildDirectory - .childDirectory('runner') - .childDirectory(sentenceCase(buildModeName)) - .childFile('${windowsProject.parent.manifest.appName}.exe'); - if (appFile.existsSync()) { - final String appSize = (buildInfo.mode == BuildMode.debug) - ? '' // Don't display the size when building a debug variant. - : ' (${getSizeAsMB(appFile.lengthSync())})'; - globals.logger.printStatus( - '${globals.logger.terminal.successMark} ' - 'Built ${globals.fs.path.relative(appFile.path)}$appSize.', - color: TerminalColor.green, - ); - } - if (buildInfo.codeSizeDirectory != null && sizeAnalyzer != null) { final String arch = getNameForTargetPlatform(TargetPlatform.windows_x64); final File codeSizeFile = globals.fs.directory(buildInfo.codeSizeDirectory)