From 36a391f689ebc9c1334059c67276819ee33196df Mon Sep 17 00:00:00 2001 From: Valentin Vignal <32538273+ValentinVignal@users.noreply.github.com> Date: Wed, 21 Aug 2024 17:45:32 +0800 Subject: [PATCH] Add tests for `SingleChildScrollView` examples (#153548) Contributes to https://github.com/flutter/flutter/issues/130459 It adds a test for - `examples/api/lib/widgets/single_child_scroll_view/single_child_scroll_view.0.dart` - `examples/api/lib/widgets/single_child_scroll_view/single_child_scroll_view.1.dart` I also fixed a mistake in the documentation --- dev/bots/check_code_samples.dart | 2 - .../single_child_scroll_view.0_test.dart | 46 +++++++++++++++ .../single_child_scroll_view.1_test.dart | 56 +++++++++++++++++++ 3 files changed, 102 insertions(+), 2 deletions(-) create mode 100644 examples/api/test/widgets/single_child_scroll_view/single_child_scroll_view.0_test.dart create mode 100644 examples/api/test/widgets/single_child_scroll_view/single_child_scroll_view.1_test.dart diff --git a/dev/bots/check_code_samples.dart b/dev/bots/check_code_samples.dart index fd7720d9ce..4622830b93 100644 --- a/dev/bots/check_code_samples.dart +++ b/dev/bots/check_code_samples.dart @@ -355,8 +355,6 @@ final Set _knownMissingTests = { 'examples/api/test/widgets/notification_listener/notification.0_test.dart', 'examples/api/test/widgets/overscroll_indicator/glowing_overscroll_indicator.1_test.dart', 'examples/api/test/widgets/overscroll_indicator/glowing_overscroll_indicator.0_test.dart', - 'examples/api/test/widgets/single_child_scroll_view/single_child_scroll_view.1_test.dart', - 'examples/api/test/widgets/single_child_scroll_view/single_child_scroll_view.0_test.dart', 'examples/api/test/widgets/restoration/restoration_mixin.0_test.dart', 'examples/api/test/widgets/actions/focusable_action_detector.0_test.dart', 'examples/api/test/widgets/focus_scope/focus_scope.0_test.dart', diff --git a/examples/api/test/widgets/single_child_scroll_view/single_child_scroll_view.0_test.dart b/examples/api/test/widgets/single_child_scroll_view/single_child_scroll_view.0_test.dart new file mode 100644 index 0000000000..4b9f59b9a7 --- /dev/null +++ b/examples/api/test/widgets/single_child_scroll_view/single_child_scroll_view.0_test.dart @@ -0,0 +1,46 @@ +// Copyright 2014 The Flutter Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +import 'package:flutter/widgets.dart'; +import 'package:flutter_api_samples/widgets/single_child_scroll_view/single_child_scroll_view.0.dart' + as example; +import 'package:flutter_test/flutter_test.dart'; + +void main() { + testWidgets('The children should be spaced out equally when the screen is big enough', (WidgetTester tester) async { + await tester.pumpWidget( + const example.SingleChildScrollViewExampleApp(), + ); + + expect(find.text('Fixed Height Content'), findsExactly(2)); + expect(tester.getTopLeft(find.byType(Container).first), const Offset(0, 90)); + expect(tester.getTopLeft(find.byType(Container).last), const Offset(0, 390)); + + await tester.fling(find.byType(SingleChildScrollView).last, const Offset(0, -100), 10.0); + + // The view should not scroll when the screen is big enough. + expect(tester.getTopLeft(find.byType(Container).first), const Offset(0, 90)); + expect(tester.getTopLeft(find.byType(Container).last), const Offset(0, 390)); + }); + + testWidgets('The view should be scrollable when the screen is not big enough', (WidgetTester tester) async { + tester.view + ..physicalSize = const Size(400, 200) + ..devicePixelRatio = 1; + addTearDown(tester.view.reset); + await tester.pumpWidget( + const example.SingleChildScrollViewExampleApp(), + ); + + expect(find.text('Fixed Height Content'), findsExactly(2)); + expect(tester.getTopLeft(find.byType(Container).first), Offset.zero); + expect(tester.getTopLeft(find.byType(Container).last), const Offset(0, 120)); + + await tester.fling(find.byType(SingleChildScrollView).last, const Offset(0, -40), 10.0); + + // The view should scroll when the screen is not big enough. + expect(tester.getTopLeft(find.byType(Container).first), const Offset(0, -40)); + expect(tester.getTopLeft(find.byType(Container).last), const Offset(0, 80)); + }); +} diff --git a/examples/api/test/widgets/single_child_scroll_view/single_child_scroll_view.1_test.dart b/examples/api/test/widgets/single_child_scroll_view/single_child_scroll_view.1_test.dart new file mode 100644 index 0000000000..1f7e4f77c4 --- /dev/null +++ b/examples/api/test/widgets/single_child_scroll_view/single_child_scroll_view.1_test.dart @@ -0,0 +1,56 @@ +// Copyright 2014 The Flutter Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +import 'package:flutter/widgets.dart'; +import 'package:flutter_api_samples/widgets/single_child_scroll_view/single_child_scroll_view.1.dart' + as example; +import 'package:flutter_test/flutter_test.dart'; + +void main() { + testWidgets('The flexible child should fill the space if the screen is big enough', (WidgetTester tester) async { + await tester.pumpWidget( + const example.SingleChildScrollViewExampleApp(), + ); + + final Finder fixedHeightFinder = find.widgetWithText(Container, 'Fixed Height Content'); + final Finder flexibleHeightFinder = find.widgetWithText(Container, 'Flexible Content'); + expect(tester.getTopLeft(fixedHeightFinder), Offset.zero); + expect(tester.getSize(fixedHeightFinder), const Size(800, 120)); + expect(tester.getTopLeft(flexibleHeightFinder), const Offset(0, 120)); + expect(tester.getSize(flexibleHeightFinder), const Size(800, 480)); + + await tester.fling(find.byType(SingleChildScrollView).last, const Offset(0, -100), 10.0); + + // The view should not scroll when the screen is big enough. + expect(tester.getTopLeft(fixedHeightFinder), Offset.zero); + expect(tester.getSize(fixedHeightFinder), const Size(800, 120)); + expect(tester.getTopLeft(flexibleHeightFinder), const Offset(0, 120)); + expect(tester.getSize(flexibleHeightFinder), const Size(800, 480)); + }); + + testWidgets('The view should be scrollable when the screen is not big enough', (WidgetTester tester) async { + tester.view + ..physicalSize = const Size(400, 200) + ..devicePixelRatio = 1; + addTearDown(tester.view.reset); + await tester.pumpWidget( + const example.SingleChildScrollViewExampleApp(), + ); + + final Finder fixedHeightFinder = find.widgetWithText(Container, 'Fixed Height Content'); + final Finder flexibleHeightFinder = find.widgetWithText(Container, 'Flexible Content'); + expect(tester.getTopLeft(fixedHeightFinder), Offset.zero); + expect(tester.getSize(fixedHeightFinder), const Size(400, 120)); + expect(tester.getTopLeft(flexibleHeightFinder), const Offset(0, 120)); + expect(tester.getSize(flexibleHeightFinder), const Size(400, 120)); + + await tester.fling(find.byType(SingleChildScrollView).last, const Offset(0, -40), 10.0); + + // The view should scroll when the screen is not big enough. + expect(tester.getTopLeft(fixedHeightFinder), const Offset(0, -40)); + expect(tester.getSize(fixedHeightFinder), const Size(400, 120)); + expect(tester.getTopLeft(flexibleHeightFinder), const Offset(0, 80)); + expect(tester.getSize(flexibleHeightFinder), const Size(400, 120)); + }); +}