firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

make showKeyboard respect finder's skipOffstage value (#79034)

Browse Source
This commit is contained in:
Michael Bui 2021-03-30 12:19:03 +11:00 committed by GitHub
parent 462ad79036
commit 39499bd2bf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 35 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter_test/lib/src/widget_tester.dart
View File

@ -1031,7 +1031,7 @@ class WidgetTester extends WidgetController implements HitTestDispatcher, Ticker
final EditableTextState editable = state<EditableTextState>( final EditableTextState editable = state<EditableTextState>(
find.descendant( find.descendant(
of: finder, of: finder,
matching: find.byType(EditableText), matching: find.byType(EditableText, skipOffstage: finder.skipOffstage),
matchRoot: true, matchRoot: true,
), ),
); );

51
packages/flutter_test/test/widget_tester_test.dart
View File

@ -611,25 +611,42 @@ void main() {
}); });
}); });
testWidgets('showKeyboard can be called twice', (WidgetTester tester) async { group('showKeyboard', () {
await tester.pumpWidget( testWidgets('can be called twice', (WidgetTester tester) async {
MaterialApp( await tester.pumpWidget(
home: Material( MaterialApp(
child: Center( home: Material(
child: TextFormField(), child: Center(
child: TextFormField(),
),
), ),
), ),
), );
); await tester.showKeyboard(find.byType(TextField));
await tester.showKeyboard(find.byType(TextField)); await tester.testTextInput.receiveAction(TextInputAction.done);
await tester.testTextInput.receiveAction(TextInputAction.done); await tester.pump();
await tester.pump(); await tester.showKeyboard(find.byType(TextField));
await tester.showKeyboard(find.byType(TextField)); await tester.testTextInput.receiveAction(TextInputAction.done);
await tester.testTextInput.receiveAction(TextInputAction.done); await tester.pump();
await tester.pump(); await tester.showKeyboard(find.byType(TextField));
await tester.showKeyboard(find.byType(TextField)); await tester.showKeyboard(find.byType(TextField));
await tester.showKeyboard(find.byType(TextField)); await tester.pump();
await tester.pump(); });
testWidgets(
'can focus on offstage text input field if finder says not to skip offstage nodes',
(WidgetTester tester) async {
await tester.pumpWidget(
MaterialApp(
home: Material(
child: Offstage(
child: TextFormField(),
),
),
),
);
await tester.showKeyboard(find.byType(TextField, skipOffstage: false));
});
}); });
testWidgets('verifyTickersWereDisposed control test', (WidgetTester tester) async { testWidgets('verifyTickersWereDisposed control test', (WidgetTester tester) async {