Rename .analysis_options to analysis_options.yaml (#11594)

CONTRIBUTING.md

@@ -76,11 +76,11 @@ main ways to run it. In either case you will want to run `flutter update-package
 first, or you will get version conflict issues or bogus error messages about core clases like
 Offset from `dart:ui`.
 
-For a one-off, use `flutter analyze --flutter-repo`. This uses the `.analysis_options_repo` file
+For a one-off, use `flutter analyze --flutter-repo`. This uses the `analysis_options_repo.yaml` file
 at the root of the repository for its configuration.
 
 For continuous analysis, use `flutter analyze --flutter-repo --watch`. This uses normal
-`.analysis_options` files, and they can differ from package to package.
+`analysis_options.yaml` files, and they can differ from package to package.
 
 If you want to see how many members are missing dartdocs, you should use the first option,
 providing the additional command `--dartdocs`.

analysis_options.yaml

@@ -8,13 +8,13 @@
 # https://github.com/dart-lang/sdk/tree/master/pkg/analyzer#configuring-the-analyzer
 #
 # There are four similar analysis options files in the flutter repos:
-#   - .analysis_options (this file)
-#   - .analysis_options_repo
+#   - analysis_options.yaml (this file)
+#   - analysis_options_repo.yaml
 #   - packages/flutter/lib/analysis_options_user.yaml
-#   - https://github.com/flutter/plugins/blob/master/.analysis_options
+#   - https://github.com/flutter/plugins/blob/master/analysis_options.yaml
 #
 # This file contains the analysis options used by Flutter editors, such as Atom.
-# It is very similar to the .analysis_options_repo file in this same directory;
+# It is very similar to the analysis_options_repo.yaml file in this same directory;
 # the only difference (currently) is the public_member_api_docs option,
 # which triggers too many messages to be used in editors.
 #
@@ -122,7 +122,7 @@ linter:
     # - prefer_interpolation_to_compose_strings # not yet tested
     - prefer_is_empty
     - prefer_is_not_empty
-    # - public_member_api_docs # this is the only difference from .analysis_options_repo
+    # - public_member_api_docs # this is the only difference from analysis_options_repo.yaml
     # - recursive_getters # https://github.com/dart-lang/linter/issues/452
     - slash_for_doc_comments
     - sort_constructors_first

analysis_options_repo.yaml

@@ -8,12 +8,12 @@
 # https://github.com/dart-lang/sdk/tree/master/pkg/analyzer#configuring-the-analyzer
 #
 # There are three similar analysis options files in the flutter repo:
-#   - .analysis_options
-#   - .analysis_options_repo (this file)
+#   - analysis_options.yaml
+#   - analysis_options_repo.yaml (this file)
 #   - packages/flutter/lib/analysis_options_user.yaml
 #
 # This file contains the analysis options used by 'flutter analyze' when analyzing
-# the flutter repository. It is very similar to .analysis_options;
+# the flutter repository. It is very similar to analysis_options.yaml;
 # the only difference (currently) is the public_member_api_docs option,
 # which is turned on and programmatically reduced to a single output line
 # indicating the # of violations for that rule.
@@ -116,7 +116,7 @@ linter:
     # - prefer_interpolation_to_compose_strings # not yet tested
     - prefer_is_empty
     - prefer_is_not_empty
-    - public_member_api_docs # this is the only difference from .analysis_options_repo
+    - public_member_api_docs # this is the only difference from analysis_options_repo.yaml
     # - recursive_getters # https://github.com/dart-lang/linter/issues/452
     - slash_for_doc_comments
     - sort_constructors_first

examples/flutter_gallery/BUILD.gn

@@ -9,7 +9,7 @@ assert(is_fuchsia)
 flutter_app("flutter_gallery") {
   main_dart = "lib/main.dart"
 
-  analysis_options = "//lib/flutter/.analysis_options"
+  analysis_options = "//lib/flutter/analysis_options.yaml"
 
   deps = [
     "//lib/flutter/packages/flutter",

packages/flutter/BUILD.gn

@@ -7,7 +7,7 @@ import("//build/dart/dart_package.gni")
 dart_package("flutter") {
   package_name = "flutter"
 
-  analysis_options = "//lib/flutter/.analysis_options"
+  analysis_options = "//lib/flutter/analysis_options.yaml"
 
   deps = [
     "//third_party/dart-pkg/pub/async",

packages/flutter/lib/analysis_options_user.yaml

@@ -8,8 +8,8 @@
 # https://github.com/dart-lang/sdk/tree/master/pkg/analyzer#configuring-the-analyzer
 #
 # There are three similar analysis options files in the flutter repo:
-#   - .analysis_options
-#   - .analysis_options_repo
+#   - analysis_options.yaml
+#   - analysis_options_repo.yaml
 #   - packages/flutter/lib/analysis_options_user.yaml (this file)
 #
 # This file contains the analysis options used by "flutter analyze"
@@ -17,7 +17,7 @@
 # It isn't named 'analysis_options.yaml' because otherwise editors like Atom
 # would use it when analyzing the flutter tool itself.
 #
-# When editing, make sure you keep /.analysis_options consistent.
+# When editing, make sure you keep /analysis_options.yaml consistent.
 
 analyzer:
   language:

packages/flutter_test/BUILD.gn

@@ -7,7 +7,7 @@ import("//build/dart/dart_package.gni")
 dart_package("flutter_test") {
   package_name = "flutter_test"
 
-  analysis_options = "//lib/flutter/.analysis_options"
+  analysis_options = "//lib/flutter/analysis_options.yaml"
 
   deps = [
     "//lib/flutter/packages/flutter",

packages/flutter_tools/BUILD.gn

@@ -8,7 +8,7 @@ import("//build/dart/dart_tool.gni")
 dart_package("flutter_tools") {
   package_name = "flutter_tools"
 
-  analysis_options = "//lib/flutter/.analysis_options"
+  analysis_options = "//lib/flutter/analysis_options.yaml"
 
   deps = [
     "//dart/pkg/analyzer",
@@ -42,7 +42,7 @@ dart_package("flutter_tools") {
 dart_tool("fuchsia_builder") {
   main_dart = "bin/fuchsia_builder.dart"
 
-  analysis_options = "//lib/flutter/.analysis_options"
+  analysis_options = "//lib/flutter/analysis_options.yaml"
 
   deps = [
     ":flutter_tools",
@@ -52,7 +52,7 @@ dart_tool("fuchsia_builder") {
 dart_tool("fuchsia_tester") {
   main_dart = "bin/fuchsia_tester.dart"
 
-  analysis_options = "//lib/flutter/.analysis_options"
+  analysis_options = "//lib/flutter/analysis_options.yaml"
 
   deps = [
     ":flutter_tools",

packages/flutter_tools/lib/src/commands/analyze_once.dart

@@ -147,7 +147,7 @@ class AnalyzeOnce extends AnalyzeBase {
     final DriverOptions options = new DriverOptions();
     options.dartSdkPath = argResults['dart-sdk'];
     options.packageMap = packages;
-    options.analysisOptionsFile = fs.path.join(Cache.flutterRoot, '.analysis_options_repo');
+    options.analysisOptionsFile = fs.path.join(Cache.flutterRoot, 'analysis_options_repo.yaml');
     final AnalysisDriver analyzer = new AnalysisDriver(options);
 
     // TODO(pq): consider error handling