From 3a976feb5803f0ff2a29c01277469d76c184bf5c Mon Sep 17 00:00:00 2001 From: Jonah Williams Date: Wed, 22 Jul 2020 18:39:33 -0700 Subject: [PATCH] [flutter_tools] clean plugin dependencies file (#62061) Clean even more, in case the plugin dependency update logic is wrong-o. --- packages/flutter_tools/lib/src/commands/clean.dart | 2 ++ .../test/commands.shard/hermetic/clean_test.dart | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/packages/flutter_tools/lib/src/commands/clean.dart b/packages/flutter_tools/lib/src/commands/clean.dart index fa2734a7cd..0caa7df80c 100644 --- a/packages/flutter_tools/lib/src/commands/clean.dart +++ b/packages/flutter_tools/lib/src/commands/clean.dart @@ -57,6 +57,8 @@ class CleanCommand extends FlutterCommand { deleteFile(flutterProject.linux.ephemeralDirectory); deleteFile(flutterProject.macos.ephemeralDirectory); deleteFile(flutterProject.windows.ephemeralDirectory); + deleteFile(flutterProject.flutterPluginsDependenciesFile); + deleteFile(flutterProject.flutterPluginsFile); return const FlutterCommandResult(ExitStatus.success); } diff --git a/packages/flutter_tools/test/commands.shard/hermetic/clean_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/clean_test.dart index 80df539e14..9a3e62c5a5 100644 --- a/packages/flutter_tools/test/commands.shard/hermetic/clean_test.dart +++ b/packages/flutter_tools/test/commands.shard/hermetic/clean_test.dart @@ -53,6 +53,8 @@ void main() { projectUnderTest.linux.ephemeralDirectory.createSync(recursive: true); projectUnderTest.macos.ephemeralDirectory.createSync(recursive: true); projectUnderTest.windows.ephemeralDirectory.createSync(recursive: true); + projectUnderTest.flutterPluginsFile.createSync(recursive: true); + projectUnderTest.flutterPluginsDependenciesFile.createSync(recursive: true); }); testUsingContext('$CleanCommand removes build and .dart_tool and ephemeral directories, cleans Xcode', () async { @@ -72,6 +74,9 @@ void main() { expect(projectUnderTest.macos.ephemeralDirectory.existsSync(), isFalse); expect(projectUnderTest.windows.ephemeralDirectory.existsSync(), isFalse); + expect(projectUnderTest.flutterPluginsFile.existsSync(), isFalse); + expect(projectUnderTest.flutterPluginsDependenciesFile.existsSync(), isFalse); + verify(mockXcodeProjectInterpreter.cleanWorkspace(any, 'Runner', verbose: false)).called(2); }, overrides: { FileSystem: () => fs,