firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Temporarily remove a bogus warning until fixed by dwds update (#109793)

Browse Source 
* Temporarily remove a bogus warning until fixed by dwds update

* Addressed CR feedback
This commit is contained in:
Anna Gringauze 2022-08-19 11:06:53 -07:00 committed by GitHub
parent dcdd3e2b09
commit 3b6e3a6938
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/flutter_tools/lib/src/isolated/devfs_web.dart
View File

@ -1042,7 +1042,12 @@ void log(logging.LogRecord event) {
if (event.level >= logging.Level.SEVERE) { if (event.level >= logging.Level.SEVERE) {
globals.printError('${event.loggerName}: ${event.message}$error', stackTrace: event.stackTrace); globals.printError('${event.loggerName}: ${event.message}$error', stackTrace: event.stackTrace);
} else if (event.level == logging.Level.WARNING) { } else if (event.level == logging.Level.WARNING) {
// Note: Temporary fix for https://github.com/flutter/flutter/issues/109792
// TODO(annagrin): Remove the condition after the bogus warning is
// removed in dwds: https://github.com/dart-lang/webdev/issues/1722
if (!event.message.contains('No module for')) {
globals.printWarning('${event.loggerName}: ${event.message}$error'); globals.printWarning('${event.loggerName}: ${event.message}$error');
}
} else { } else {
globals.printTrace('${event.loggerName}: ${event.message}$error'); globals.printTrace('${event.loggerName}: ${event.message}$error');
} }

1
packages/flutter_tools/test/web.shard/expression_evaluation_web_test.dart
View File

@ -23,6 +23,7 @@ void main() {
flutter = FlutterRunTestDriver(tempDir); flutter = FlutterRunTestDriver(tempDir);
flutter.stdout.listen((String line) { flutter.stdout.listen((String line) {
expect(line, isNot(contains('Unresolved uri:'))); expect(line, isNot(contains('Unresolved uri:')));
expect(line, isNot(contains('No module for')));
}); });
}); });