From 3bd1737c0ea54d57fe8f0b39052503af4589b032 Mon Sep 17 00:00:00 2001 From: Gary Qian Date: Fri, 3 May 2019 12:32:04 -0700 Subject: [PATCH] Partially Rollback caret change for Android (#32043) --- packages/flutter/lib/src/rendering/editable.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/flutter/lib/src/rendering/editable.dart b/packages/flutter/lib/src/rendering/editable.dart index 30a9821245..69199e4642 100644 --- a/packages/flutter/lib/src/rendering/editable.dart +++ b/packages/flutter/lib/src/rendering/editable.dart @@ -1503,7 +1503,7 @@ class RenderEditable extends RenderBox { case TargetPlatform.iOS: return Rect.fromLTWH(0.0, 0.0, cursorWidth, preferredLineHeight + 2); default: - return Rect.fromLTWH(0.0, 0.0, cursorWidth, preferredLineHeight - 2.0 * _kCaretHeightOffset); + return Rect.fromLTWH(0.0, _kCaretHeightOffset, cursorWidth, preferredLineHeight - 2.0 * _kCaretHeightOffset); } } @override @@ -1569,7 +1569,7 @@ class RenderEditable extends RenderBox { // TODO(garyq): See the TODO for _getCaretPrototype. caretRect = Rect.fromLTWH( caretRect.left, - caretRect.top, + caretRect.top - _kCaretHeightOffset, caretRect.width, _textPainter.getFullHeightForCaret(textPosition, _caretPrototype), );