firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

flutter run should fail if pub get fails.

Browse Source 
Previously we were ignoring the return code and continuing.

@devoncarew
This commit is contained in:
Eric Seidel 2016-03-10 09:32:25 -08:00
parent 8f603800ba
commit 3e2a4d9b4d
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/flutter_tools/lib/src/commands/run.dart
View File

@ -81,8 +81,11 @@ class RunCommand extends RunCommandBase {
@override @override
Future<int> run() async { Future<int> run() async {
if (argResults['pub']) if (argResults['pub']) {
await pubGet(); int exitCode = await pubGet();
if (exitCode != 0)
return exitCode;
}
return await super.run(); return await super.run();
} }

2
packages/flutter_tools/lib/src/commands/update_packages.dart
View File

@ -15,6 +15,8 @@ Future<int> _runPub(Directory directory, { bool upgrade: false }) async {
for (FileSystemEntity dir in directory.listSync()) { for (FileSystemEntity dir in directory.listSync()) {
if (dir is Directory && FileSystemEntity.isFileSync(dir.path + Platform.pathSeparator + 'pubspec.yaml')) { if (dir is Directory && FileSystemEntity.isFileSync(dir.path + Platform.pathSeparator + 'pubspec.yaml')) {
updateCount++; updateCount++;
// TODO(eseidel): Should this fail immediately if pubGet fails?
// Currently we're ignoring the return code.
await pubGet(directory: dir.path, upgrade: upgrade, checkLastModified: false); await pubGet(directory: dir.path, upgrade: upgrade, checkLastModified: false);
} }
} }