firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[web] Unskip assertions test. Update for latest stack trace format. (#53795)

Browse Source
This commit is contained in:
Ferhat 2020-04-02 10:46:01 -07:00 committed by GitHub
parent 1c8b81fae1
commit 40aea47992
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/flutter/lib/src/foundation/assertions.dart
View File

@ -926,6 +926,7 @@ void debugPrintStack({StackTrace stackTrace, String label, int maxFrames}) {
// is addressed. // is addressed.
lines = lines.skipWhile((String line) { lines = lines.skipWhile((String line) {
return line.contains('StackTrace.current') || return line.contains('StackTrace.current') ||
line.contains('dart-sdk/lib/_internal') ||
line.contains('dart:sdk_internal'); line.contains('dart:sdk_internal');
}); });
} }

4
packages/flutter/test/foundation/assertions_test.dart
View File

@ -14,7 +14,7 @@ void main() {
}); });
expect(log[0], contains('Example label')); expect(log[0], contains('Example label'));
expect(log[1], contains('debugPrintStack')); expect(log[1], contains('debugPrintStack'));
}, skip: isBrowser); });
test('debugPrintStack', () { test('debugPrintStack', () {
final List<String> log = captureOutput(() { final List<String> log = captureOutput(() {
@ -39,7 +39,7 @@ void main() {
expect(joined, contains('captureOutput')); expect(joined, contains('captureOutput'));
expect(joined, contains('\nExample information\n')); expect(joined, contains('\nExample information\n'));
}, skip: isBrowser); });
test('FlutterErrorDetails.toString', () { test('FlutterErrorDetails.toString', () {
expect( expect(