Make PipelineOwner a base class (#161789)

Such that nobody `implements` it. Currently it has private APIs used by
the `RenderObject` class (e.g., the dirty lists). If someone were to
implement a `PipelineOwner` outside of object.dart, they will get a
runtime `noSuchMethod` crash since they won't be able to provide those
private APIs and RenderObjects actually expect those APIs to exist.

Will be slow to update/respond due to extremely spotty internet :(

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This commit is contained in:
LongCatIsLooong 2025-01-20 17:46:25 -08:00 committed by GitHub
parent 883ef85413
commit 4115a78d2c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 3 additions and 3 deletions

View File

@ -827,7 +827,7 @@ class _BindingPipelineManifold extends ChangeNotifier implements PipelineManifol
} }
// A [PipelineOwner] that cannot have a root node. // A [PipelineOwner] that cannot have a root node.
class _DefaultRootPipelineOwner extends PipelineOwner { final class _DefaultRootPipelineOwner extends PipelineOwner {
_DefaultRootPipelineOwner() : super(onSemanticsUpdate: _onSemanticsUpdate); _DefaultRootPipelineOwner() : super(onSemanticsUpdate: _onSemanticsUpdate);
@override @override

View File

@ -961,7 +961,7 @@ class _LocalSemanticsHandle implements SemanticsHandle {
/// without tying it to a specific binding implementation. All [PipelineOwner]s /// without tying it to a specific binding implementation. All [PipelineOwner]s
/// in a given tree must be attached to the same [PipelineManifold]. This /// in a given tree must be attached to the same [PipelineManifold]. This
/// happens automatically during [adoptChild]. /// happens automatically during [adoptChild].
class PipelineOwner with DiagnosticableTreeMixin { base class PipelineOwner with DiagnosticableTreeMixin {
/// Creates a pipeline owner. /// Creates a pipeline owner.
/// ///
/// Typically created by the binding (e.g., [RendererBinding]), but can be /// Typically created by the binding (e.g., [RendererBinding]), but can be

View File

@ -200,7 +200,7 @@ class FakeFlutterView extends Fake implements FlutterView {
} }
} }
class PipelineOwnerSpy extends PipelineOwner { final class PipelineOwnerSpy extends PipelineOwner {
@override @override
final SemanticsOwnerSpy semanticsOwner = SemanticsOwnerSpy(); final SemanticsOwnerSpy semanticsOwner = SemanticsOwnerSpy();
} }