firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Modified DataRow to be disabled when onSelectChanged is not set (#80184)

Browse Source 
This change prevents DataRow from being enabled when onSelectChanged is null.
This commit is contained in:
Chinmoy 2021-04-20 23:40:48 +05:30 committed by GitHub
parent 728a193383
commit 430c57eb3f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 37 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/flutter/lib/src/material/data_table.dart
View File

@ -1018,7 +1018,7 @@ class DataTable extends StatelessWidget {
tableRows[rowIndex].children![0] = _buildCheckbox(
context: context,
checked: row.selected,
onRowTap: () => row.onSelectChanged?.call(!row.selected),
onRowTap: row.onSelectChanged == null ? null : () => row.onSelectChanged?.call(!row.selected),
onCheckboxChanged: row.onSelectChanged,
overlayColor: row.color ?? effectiveDataRowColor,
tristate: false,
@ -1084,7 +1084,7 @@ class DataTable extends StatelessWidget {
onLongPress: cell.onLongPress,
onTapCancel: cell.onTapCancel,
onTapDown: cell.onTapDown,
onSelectChanged: () => row.onSelectChanged?.call(!row.selected),
onSelectChanged: row.onSelectChanged == null ? null : () => row.onSelectChanged?.call(!row.selected),
overlayColor: row.color ?? effectiveDataRowColor,
);
rowIndex += 1;

35
packages/flutter/test/material/data_table_test.dart
View File

@ -1629,4 +1629,39 @@ void main() {
_customHorizontalMargin,
);
});
testWidgets('DataRow is disabled when onSelectChanged is not set', (WidgetTester tester) async {
await tester.pumpWidget(
MaterialApp(
home: Material(
child: DataTable(
columns: const <DataColumn>[
DataColumn(label: Text('Col1')),
DataColumn(label: Text('Col2')),
],
rows: <DataRow>[
DataRow(cells: const <DataCell>[
DataCell(Text('Hello')),
DataCell(Text('world')),
],
onSelectChanged: (bool? value) {},
),
const DataRow(cells: <DataCell>[
DataCell(Text('Bug')),
DataCell(Text('report')),
]),
const DataRow(cells: <DataCell>[
DataCell(Text('GitHub')),
DataCell(Text('issue')),
]),
],
),
),
),
);
expect(find.widgetWithText(TableRowInkWell, 'Hello'), findsOneWidget);
expect(find.widgetWithText(TableRowInkWell, 'Bug'), findsNothing);
expect(find.widgetWithText(TableRowInkWell, 'GitHub'), findsNothing);
});
}