firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[flutter_tools] Fix incorrect todo (#94597)

Browse Source
This commit is contained in:
Jia Hao 2021-12-04 03:34:10 +08:00 committed by GitHub
parent 885a1482f8
commit 4517d16b53
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter_tools/lib/src/commands/test.dart
View File

@ -415,7 +415,7 @@ class TestCommand extends FlutterCommand with DeviceBasedDevelopmentArtifacts {
); );
} }
if (integrationTestDevice.platformType == PlatformType.web) { if (integrationTestDevice.platformType == PlatformType.web) {
// TODO(jiahaog): Support web. https://github.com/flutter/flutter/pull/74236 // TODO(jiahaog): Support web. https://github.com/flutter/flutter/issues/66264
throwToolExit('Web devices are not supported for integration tests yet.'); throwToolExit('Web devices are not supported for integration tests yet.');
} }

2
packages/flutter_tools/test/commands.shard/hermetic/test_test.dart
View File

@ -561,7 +561,7 @@ dev_dependencies:
DeviceManager: () => _FakeDeviceManager(<Device>[]), DeviceManager: () => _FakeDeviceManager(<Device>[]),
}); });
// TODO(jiahaog): Remove this when web is supported. https://github.com/flutter/flutter/pull/74236 // TODO(jiahaog): Remove this when web is supported. https://github.com/flutter/flutter/issues/66264
testUsingContext('Integration tests when only web devices are connected', () async { testUsingContext('Integration tests when only web devices are connected', () async {
final FakeFlutterTestRunner testRunner = FakeFlutterTestRunner(0); final FakeFlutterTestRunner testRunner = FakeFlutterTestRunner(0);