fix slider semantic label (#162304)
Added a `label` argument to the `Semantics` widget which the `Slider` widget creates. This exposes the `Slider`s label to assistive technologies so they can stop speaking "Slider". - Fixes #162067 --------- Co-authored-by: Hannah Jin <jhy03261997@gmail.com>
This commit is contained in:
parent
0444dda508
commit
4619574834
@ -989,6 +989,7 @@ class _SliderState extends State<Slider> with TickerProviderStateMixin {
|
|||||||
}
|
}
|
||||||
|
|
||||||
return Semantics(
|
return Semantics(
|
||||||
|
label: widget.label,
|
||||||
container: true,
|
container: true,
|
||||||
slider: true,
|
slider: true,
|
||||||
onDidGainAccessibilityFocus: handleDidGainAccessibilityFocus,
|
onDidGainAccessibilityFocus: handleDidGainAccessibilityFocus,
|
||||||
|
@ -1767,6 +1767,7 @@ void main() {
|
|||||||
testWidgets('Slider.label info should not write to semantic node', (WidgetTester tester) async {
|
testWidgets('Slider.label info should not write to semantic node', (WidgetTester tester) async {
|
||||||
final SemanticsTester semantics = SemanticsTester(tester);
|
final SemanticsTester semantics = SemanticsTester(tester);
|
||||||
|
|
||||||
|
const String label = 'Bingo';
|
||||||
await tester.pumpWidget(
|
await tester.pumpWidget(
|
||||||
MaterialApp(
|
MaterialApp(
|
||||||
home: Directionality(
|
home: Directionality(
|
||||||
@ -1778,7 +1779,7 @@ void main() {
|
|||||||
divisions: 10,
|
divisions: 10,
|
||||||
semanticFormatterCallback: (double value) => value.round().toString(),
|
semanticFormatterCallback: (double value) => value.round().toString(),
|
||||||
onChanged: (double v) {},
|
onChanged: (double v) {},
|
||||||
label: 'Bingo',
|
label: label,
|
||||||
),
|
),
|
||||||
),
|
),
|
||||||
),
|
),
|
||||||
@ -1818,6 +1819,7 @@ void main() {
|
|||||||
increasedValue: '60',
|
increasedValue: '60',
|
||||||
decreasedValue: '20',
|
decreasedValue: '20',
|
||||||
textDirection: TextDirection.ltr,
|
textDirection: TextDirection.ltr,
|
||||||
|
label: label,
|
||||||
),
|
),
|
||||||
],
|
],
|
||||||
),
|
),
|
||||||
|
Loading…
x
Reference in New Issue
Block a user