From 46cb56d313c07eba302da375ff0d9cacb043a0ea Mon Sep 17 00:00:00 2001 From: hgraceb <38378650+hgraceb@users.noreply.github.com> Date: Thu, 18 Jul 2024 00:34:53 +0800 Subject: [PATCH] Remove redundant assignment of geometry (#151821) Remove redundant assignment of geometry. --- AUTHORS | 1 + .../lib/src/rendering/sliver_persistent_header.dart | 11 ----------- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/AUTHORS b/AUTHORS index f009a150eb..0a56019d1a 100644 --- a/AUTHORS +++ b/AUTHORS @@ -125,3 +125,4 @@ Amir Panahandeh Kostiantyn Sokolovskyi Valentin Vignal Cedric Vanden Bosch +Flop diff --git a/packages/flutter/lib/src/rendering/sliver_persistent_header.dart b/packages/flutter/lib/src/rendering/sliver_persistent_header.dart index 347df0201e..aca31fac11 100644 --- a/packages/flutter/lib/src/rendering/sliver_persistent_header.dart +++ b/packages/flutter/lib/src/rendering/sliver_persistent_header.dart @@ -365,20 +365,9 @@ abstract class RenderSliverScrollingPersistentHeader extends RenderSliverPersist return stretchOffset > 0 ? 0.0 : math.min(0.0, paintExtent - childExtent); } - @override void performLayout() { - final SliverConstraints constraints = this.constraints; - final double maxExtent = this.maxExtent; layoutChild(constraints.scrollOffset, maxExtent); - final double paintExtent = maxExtent - constraints.scrollOffset; - geometry = SliverGeometry( - scrollExtent: maxExtent, - paintOrigin: math.min(constraints.overlap, 0.0), - paintExtent: clampDouble(paintExtent, 0.0, constraints.remainingPaintExtent), - maxPaintExtent: maxExtent, - hasVisualOverflow: true, // Conservatively say we do have overflow to avoid complexity. - ); _childPosition = updateGeometry(); }