firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix a couple of covariant overrides in Expression. (#5257)

Browse Source 
It was widening the return type of a couple of operators compared to
what EquationMember declared it should return. Since it did in fact
always return an Expression, the widening wasn't needed.

This just tightens them to match the base class.
This commit is contained in:
Bob Nystrom 2016-08-05 12:16:58 -07:00 committed by Ian Hickson
parent 81b4e827e1
commit 47139f1da9
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/flutter/lib/src/cassowary/expression.dart
View File

@ -148,7 +148,7 @@ class Expression extends EquationMember {
}
@override
EquationMember operator *(EquationMember m) {
Expression operator *(EquationMember m) {
_Multiplication args = _findMulitplierAndMultiplicand(m);
if (args == null) {
@ -162,7 +162,7 @@ class Expression extends EquationMember {
}
@override
EquationMember operator /(EquationMember m) {
Expression operator /(EquationMember m) {
if (!m.isConstant) {
throw new ParserException(
'The divisor was not a constant expression', <EquationMember>[this, m]);
@ -187,7 +187,7 @@ class Expression extends EquationMember {
return null;
}
EquationMember _applyMultiplicand(double m) {
Expression _applyMultiplicand(double m) {
List<Term> newTerms = terms.fold(
new List<Term>(),
(List<Term> list, Term term) {