firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update stack trace test goldens to handle engine builds with lazy async stacks (#51216)

Browse Source 
The next engine roll will introduce --lazy-async-stacks, which affects the
contents of stack traces.  This updates test expectations to match both the
old and new stack trace formats.
This commit is contained in:
Jason Simmons 2020-02-21 12:05:30 -08:00 committed by GitHub
parent d5844e8a4a
commit 479e27c9f1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dev/automated_tests/flutter_test/exception_handling_expectation.txt
View File

@ -9,7 +9,7 @@ When the exception was thrown, this was the stack:
#(1|2) .+ \(package:flutter_test[/\\]src[/\\]widget_tester\.dart:[0-9]+:[0-9]+\) #(1|2) .+ \(package:flutter_test[/\\]src[/\\]widget_tester\.dart:[0-9]+:[0-9]+\)
<asynchronous suspension> <asynchronous suspension>
<<skip until matching line>> <<skip until matching line>>
^\(elided [0-9]+ frames.+$ ^\(elided ([0-9]+|one) frame.+$
<<skip until matching line>> <<skip until matching line>>
The test description was: The test description was:
Exception handling in test harness - string Exception handling in test harness - string
@ -29,7 +29,7 @@ When the exception was thrown, this was the stack:
#(1|2) .+ \(package:flutter_test[/\\]src[/\\]widget_tester\.dart:[0-9]+:[0-9]+\) #(1|2) .+ \(package:flutter_test[/\\]src[/\\]widget_tester\.dart:[0-9]+:[0-9]+\)
<asynchronous suspension> <asynchronous suspension>
<<skip until matching line>> <<skip until matching line>>
^\(elided [0-9]+ .+$ ^\(elided ([0-9]+|one) .+$
<<skip until matching line>> <<skip until matching line>>
The test description was: The test description was:
Exception handling in test harness - FlutterError Exception handling in test harness - FlutterError
@ -52,7 +52,7 @@ When the exception was thrown, this was the stack:
<<skip until matching line>> <<skip until matching line>>
#[0-9]+ +.+ \(package:flutter_test[/\\]src[/\\]widget_tester\.dart:[0-9]+:[0-9]+\) #[0-9]+ +.+ \(package:flutter_test[/\\]src[/\\]widget_tester\.dart:[0-9]+:[0-9]+\)
<<skip until matching line>> <<skip until matching line>>
^\(elided [0-9]+ .+$ ^\(elided ([0-9]+|one) .+$
<<skip until matching line>> <<skip until matching line>>
The test description was: The test description was:
Exception handling in test harness - uncaught Future error Exception handling in test harness - uncaught Future error

4
dev/automated_tests/flutter_test/test_async_utils_unguarded_expectation.txt
View File

@ -15,11 +15,11 @@ statement in front of the call to the first\.
When the first method was called, this was the stack: When the first method was called, this was the stack:
<<skip until matching line>> <<skip until matching line>>
(elided [0-9]+ frames from .+) (elided ([0-9]+|one) frames? from .+)
When the exception was thrown, this was the stack: When the exception was thrown, this was the stack:
<<skip until matching line>> <<skip until matching line>>
(elided [0-9]+ frames from .+) (elided ([0-9]+|one) frames? from .+)
The test description was: The test description was:
TestAsyncUtils - handling unguarded async helper functions TestAsyncUtils - handling unguarded async helper functions