firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Impeller] disable AHB swapchains on all platforms. (flutter/engine#57213)

Browse Source 
Disabling until we figure out if we can even use this.
This commit is contained in:
Jonah Williams 2024-12-16 09:27:56 -08:00 committed by GitHub
parent 0bc174d87a
commit 481ee0e64f
1 changed files with 0 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
engine/src/flutter/impeller/renderer/backend/vulkan/swapchain/swapchain_vk.cc
View File

@ -56,31 +56,6 @@ std::shared_ptr<SwapchainVK> SwapchainVK::Create(
return nullptr;
}
// TODO(147533): AHB swapchains on emulators are not functional.
auto& context_vk = ContextVK::Cast(*context);
const auto emulator = context_vk.GetDriverInfo()->IsEmulator();
const auto should_disable_sc =
context_vk.GetShouldDisableSurfaceControlSwapchain();
// Try AHB swapchains first.
if (!emulator && AHBSwapchainVK::IsAvailableOnPlatform() &&
!android::ShadowRealm::ShouldDisableAHB() && !should_disable_sc) {
auto ahb_swapchain = std::shared_ptr<AHBSwapchainVK>(new AHBSwapchainVK(
context, //
window.GetHandle(), //
surface, //
window.GetSize(), //
enable_msaa //
));
if (ahb_swapchain->IsValid()) {
return ahb_swapchain;
} else {
VALIDATION_LOG
<< "Could not create AHB swapchain. Falling back to KHR variant.";
}
}
// Fallback to KHR swapchains if AHB swapchains aren't available.
return Create(context, std::move(surface), window.GetSize(), enable_msaa);
}