firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

compare to null with == (#21944)

Browse Source 
* compare to null with ==

* address review comments
This commit is contained in:
Alexandre Ardhuin 2018-10-01 21:22:51 +02:00 committed by GitHub
parent 224f91e386
commit 48fb726b01
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/flutter/lib/src/painting/box_decoration.dart
View File

@ -83,11 +83,10 @@ class BoxDecoration extends Decoration {
this.backgroundBlendMode, this.backgroundBlendMode,
this.shape = BoxShape.rectangle, this.shape = BoxShape.rectangle,
}) : assert(shape != null), }) : assert(shape != null),
// TODO(mattcarroll): Use "backgroundBlendMode == null" when https://github.com/dart-lang/sdk/issues/34180 is in.
assert( assert(
identical(backgroundBlendMode, null) || color != null || gradient != null, backgroundBlendMode == null || color != null || gradient != null,
'backgroundBlendMode applies to BoxDecoration\'s background color or ' 'backgroundBlendMode applies to BoxDecoration\'s background color or '
'gradient, but no color or gradient were provided.' 'gradient, but no color or gradient was provided.'
); );
@override @override

4
packages/flutter/lib/src/painting/text_style.dart
View File

@ -246,9 +246,7 @@ class TextStyle extends Diagnosticable {
String package, String package,
}) : fontFamily = package == null ? fontFamily : 'packages/$package/$fontFamily', }) : fontFamily = package == null ? fontFamily : 'packages/$package/$fontFamily',
assert(inherit != null), assert(inherit != null),
// TODO(dnfield): once https://github.com/dart-lang/sdk/issues/33408 is finished, this can be replaced with assert(color == null || foreground == null, _kColorForegroundWarning);
// assert(color == null || foreground == null, _kColorForegroundWarning);
assert(identical(color, null) || identical(foreground, null), _kColorForegroundWarning);
/// Whether null values are replaced with their value in an ancestor text /// Whether null values are replaced with their value in an ancestor text