firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update README.md (#29369)

Browse Source
This commit is contained in:
Dan Field 2019-03-15 08:58:13 -07:00 committed by Jonah Williams
parent d6cc949970
commit 4906c7ea56
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
dev/bots/README.md
View File

@ -91,12 +91,9 @@ The typical cycle for editing a recipe is:
existing expected output to match the new output. Verify completely new test existing expected output to match the new output. Verify completely new test
cases by altering the `GenTests` method of the recipe. The recipe is required cases by altering the `GenTests` method of the recipe. The recipe is required
to have 100% test coverage. to have 100% test coverage.
3. Run `build/scripts/slave/recipes.py run flutter/<repo> slavename=<slavename> 3. Run `led get-builder 'luci.flutter.prod:BUILDER_NAME' | led edit -p 'revision="GIT_HASH"' | led edit-recipe-bundle | led launch`, where `BUILDER_NAME` is the builder name (e.g. `Linux Engine`), and
mastername=client.flutter buildername=<buildername> `GIT_HASH` is the hash to build (which is important for the engine but not
buildnumber=1234` where `<repo>` is one of `flutter` or `engine`, and for the framework).
`slavename` and `buildername` can be looked up from the *Build Properties*
section of a [recent
build](https://build.chromium.org/p/client.flutter/one_line_per_build).
4. To submit a CL, you need a local branch first (`git checkout -b [some branch name]`). 4. To submit a CL, you need a local branch first (`git checkout -b [some branch name]`).
5. Upload the patch (`git commit`, `git cl upload`) and send it to someone in 5. Upload the patch (`git commit`, `git cl upload`) and send it to someone in
the `recipes/flutter/OWNERS` file for review. the `recipes/flutter/OWNERS` file for review.